Skip to content

RTX changes pulled in from d20b8aa #6045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 16, 2018

Conversation

deepikabhavnani
Copy link

Secure functions were not accessible from Timer/Idle thread this PR should fix that with changes from CMSIS and config options in mbed-os

Pulling in ARM-software/CMSIS_5@d20b8aa#diff-7467c87f859f0e1a8e5f93ef0c118c43

Resolves: ARM-software/CMSIS_5#252

@bulislaw - I am not sure if we should add conf options (MBED_CONF_APP_IDLE_THREAD_TZ_MOD_ID / MBED_CONF_APP_TIMER_THREAD_TZ_MOD_ID) or simply set OS_TIMER_THREAD_TZ_MOD_ID /
OS_IDLE_THREAD_TZ_MOD_ID as 1.

RTX5: Added TrustZone Module Identifier configuration for Idle and Timer Thread
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 9, 2018

Pulling in ARM-software/CMSIS_5@d20b8aa#diff-7467c87f859f0e1a8e5f93ef0c118c43

Is this pulling just one change, should not we update the RTX from upstream ?

@deepikabhavnani
Copy link
Author

RTX update will take time, and this was requires for cortex-m23/m33 devices.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 9, 2018

Build : SUCCESS

Build number : 1102
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6045/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 9, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 9, 2018

@bulislaw
Copy link
Member

bulislaw commented Feb 9, 2018

I am not sure if we should add conf options (MBED_CONF_APP_IDLE_THREAD_TZ_MOD_ID / MBED_CONF_APP_TIMER_THREAD_TZ_MOD_ID) or simply set OS_TIMER_THREAD_TZ_MOD_ID /
OS_IDLE_THREAD_TZ_MOD_ID as 1.

Are these config options expected to be changed by the APP?

Also Mbed OS won't be run in secure mode, so I'm not 100% sure why do we need that change.

@deepikabhavnani
Copy link
Author

These config options are not app based, but target based. If timer module / access to sleep mode is set as secure then non-secure mbed-os should set it to 1 to access secure modules.

@bulislaw
Copy link
Member

bulislaw commented Feb 9, 2018

If it's target specific we shouldn't use the mbed config system, but just wrap the RTX config in #ifndef.

Default value for timer/idle thread trustzone identifier is 0, updated
it to 1 to allow threads to access secure functions when timer is secure device.
@deepikabhavnani
Copy link
Author

@bulislaw - Removed the conf option

@deepikabhavnani
Copy link
Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 13, 2018

Build : SUCCESS

Build number : 1131
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6045/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 14, 2018

@cmonr cmonr merged commit 342e3ca into ARMmbed:master Feb 16, 2018
@deepikabhavnani deepikabhavnani deleted the thread_tzoption branch February 16, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure functions not accessible from Timer/Idle thread
5 participants