Skip to content

remove magic calibration value for HSI in ST's targets #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2018
Merged

remove magic calibration value for HSI in ST's targets #6070

merged 1 commit into from
Feb 12, 2018

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Feb 12, 2018

Description

Magical value coming out of the blue are evil.
This PR replaces the value set to HSICalibrationValue with RCC_HSICALIBRATION_DEFAULT on ST's targets.
(This was noticed by @kivaisan).

Status

READY

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when magic values disappear!

@cmonr
Copy link
Contributor

cmonr commented Feb 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

Build : SUCCESS

Build number : 1120
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6070/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 12, 2018

@cmonr cmonr merged commit ccff46d into ARMmbed:master Feb 12, 2018
@ithinuel ithinuel deleted the remove-magic branch February 12, 2018 23:22
@jeromecoutant
Copy link
Collaborator

Hi

Note that RCC_HSICALIBRATION_DEFAULT value is 16 !

Anyway, this is better like this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants