Remove ticker interface initialization while Ticker creation. #6076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticker constructor calls directly target specific ticker init function. Currently there is no problem, since ticker interface initialization functions are protected against multi-calls and simply returns if not called for the first time (interface initialization can be performed only once). According to the new Thicker HAL API requirements: The function ticker_init allows the ticker to keep counting and disables the ticker interrupt. Disabling interrupts while some Ticker interrupts are already scheduled for sure will destroy the schedule. Ticker interface should be initialized only once and it is already done by: static void initialize(const ticker_data_t *ticker) function in /m-bed/hal/mbed_ticker_api.c file.
|
destination branch master rather than quoted ticker feature branch? |
I think that this one can go on master since new version of the mbed ticker hal API is also on master (/m-bed/hal/mbed_ticker_api.c). |
|
/morph build |
Build : SUCCESSBuild number : 1124 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 801 |
Test : SUCCESSBuild number : 931 |
0xc0170
approved these changes
Feb 14, 2018
bulislaw
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticker constructor calls directly target specific ticker init function. Currently there is no problem, since ticker interface initialization functions are protected against multi-calls and simply returns if not called for the first time (interface initialization can be performed only once). According to the new Thicker HAL API requirements:
Disabling interrupts while some Ticker interrupts are already scheduled for sure will destroy the schedule. Ticker interface should be initialized only here:
mbed-os/hal/mbed_ticker_api.c
Line 36 in ccff46d
This function is protected against multi-calls and ensures that ticker interface will be initialized only once.
Status
READY
Migrations
NO
Related PRs
List related PRs against other branches: