Skip to content

mbed-mesh-api: add JSON help #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2018
Merged

mbed-mesh-api: add JSON help #6092

merged 2 commits into from
Mar 15, 2018

Conversation

kjbracey
Copy link
Contributor

This pulls in the help that was in the Markdown moved from this repo to the handbook in #5731 and being discussed in ARMmbed/mbed-os-5-docs#366

0xc0170
0xc0170 previously approved these changes Feb 14, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

@karsev and @AnotherButler Can you review the pull request?

@kseverinkangas-zg
Copy link

Could you add the following to the help text ->
PSKd: uppercase alphanumeric characters (0-9,A-Y excluding I,O,Q, and Z) 6 to 32 characters.
Network name: max 16 characters.

AnotherButler
AnotherButler previously approved these changes Feb 28, 2018
@cmonr
Copy link
Contributor

cmonr commented Mar 6, 2018

@kjbracey-arm Thoughts on @karsev's comment?

@kjbracey kjbracey dismissed stale reviews from AnotherButler and 0xc0170 via ba30624 March 6, 2018 08:59
@@ -46,7 +46,7 @@
"value": "NET_6LOWPAN_ROUTER"
},
"thread-pskd": {
"help": "Human-scaled commissioning credentials (string 6-255 chars).",
"help": "Human-scaled commissioning credentials. Uppercase alphanumeric string (0-9, A-Y excluding I, O, Q and Z), 6-32 characters).",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be that guy, but you have an extra ) at the end of the sentence.
Once it's gone, I'll start CI. Feel free to squash your commits as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will keep as 2 commits, as first is just transplanting existing help text from other places, the second is new edits.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

@AnotherButler Happy with this json help?

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1419
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6092/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

Test CI canceled due to 5.8.0-RC2 generation. Will resume once 5.8.0-RC2 is released.

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

Making a note: Exporter Build failure unrelated to PR. Will restart when able.

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@0xc0170 0xc0170 removed the needs: CI label Mar 15, 2018
@cmonr cmonr merged commit abb74e8 into ARMmbed:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants