-
Notifications
You must be signed in to change notification settings - Fork 3k
mbed-mesh-api: add JSON help #6092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@karsev and @AnotherButler Can you review the pull request? |
Could you add the following to the help text -> |
@kjbracey-arm Thoughts on @karsev's comment? |
@@ -46,7 +46,7 @@ | |||
"value": "NET_6LOWPAN_ROUTER" | |||
}, | |||
"thread-pskd": { | |||
"help": "Human-scaled commissioning credentials (string 6-255 chars).", | |||
"help": "Human-scaled commissioning credentials. Uppercase alphanumeric string (0-9, A-Y excluding I, O, Q and Z), 6-32 characters).", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to be that guy, but you have an extra )
at the end of the sentence.
Once it's gone, I'll start CI. Feel free to squash your commits as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Will keep as 2 commits, as first is just transplanting existing help text from other places, the second is new edits.
/morph build |
@AnotherButler Happy with this json help? |
Build : SUCCESSBuild number : 1419 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1066 |
Test CI canceled due to 5.8.0-RC2 generation. Will resume once 5.8.0-RC2 is released. |
Making a note: Exporter Build failure unrelated to PR. Will restart when able. |
/morph test |
Exporter Build : SUCCESSBuild number : 1081 |
Test : SUCCESSBuild number : 1214 |
This pulls in the help that was in the Markdown moved from this repo to the handbook in #5731 and being discussed in ARMmbed/mbed-os-5-docs#366