tests-events-timing: print debug info only in case of failure #6135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the 'Testing accuracy of equeue semaphore' test case result is printed out in each loop iteration. Since debug prints should not exist in the final test version I suggest to print information only in case of failure. Additionally time needed to print single info is equal to ~25 ms (K64F/GCC_ARM). The while loop is designed to execute until 20000 ms elapses, so this print has also impact on number of times the loop is executed (number of semaphore accuracy checks).
0xc0170
approved these changes
Feb 19, 2018
|
/morph build |
Build : SUCCESSBuild number : 1168 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 844 |
Test : SUCCESSBuild number : 974 |
0xc0170
changed the title
Exporter Build : FAILUREBuild number : 850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
Testing accuracy of equeue semaphoretest case result is printed out in each loop iteration. This gives lots of prints during test case execution.Since debug prints should not exist in the final test version I suggest to print information only in case of failure.
Additionally time needed to print single info is about ~25 ms (K64F/GCC_ARM). The while loop is designed to execute until 20000 ms elapses, so this print has also impact on number of times the loop is executed (number of semaphore accuracy checks).
Status
READY
Migrations
NO