Fix typos in the files #6149

bmcdonnell-ionx · 2018-02-21T01:20:27Z

Description

Fix a bunch of typos.

(I used grep/sed to find and fix repeats.)

Status

READY

mbed-ci · 2018-02-21T01:20:28Z

--none--

0xc0170 · 2018-02-21T08:19:56Z

/morph build

0xc0170

The most looks good, thanks for the fixes

What I would not touch are 3rd party code. They might get overwritten by the next updates.

0xc0170 · 2018-02-21T08:50:03Z

targets/TARGET_STM/TARGET_STM32L4/device/stm32l4xx_hal_sai.c

@@ -1469,7 +1469,7 @@ void HAL_SAI_IRQHandler(SAI_HandleTypeDef *hsai)
    uint32_t cr1config = hsai->Instance->CR1;
    uint32_t tmperror;

-    /* SAI Fifo request interrupt occured ------------------------------------*/
+    /* SAI Fifo request interrupt occurred -----------------------------------*/


for 3rd party files, we should not change them for easier integration.

@ARMmbed/team-st-mcd Please review

mbed-ci · 2018-02-21T08:59:08Z

Build : SUCCESS

Build number : 1192
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-02-21T10:16:29Z

Test : SUCCESS

Build number : 995
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6149/995

mbed-ci · 2018-02-21T11:07:34Z

Exporter Build : SUCCESS

Build number : 866
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6149/

0xc0170 · 2018-02-21T14:32:49Z

We reviewed the changed files , we should not change 3rd party code.

Folders to apply to:

TESTS
drivers
events
features/filesystem/bd
features/filesystem/littlefs
features/netsocket
features/storage/FEATURE_STORAGE/cfstore
hal
platform
tools

Please leave any changes outside of these folders

bcostm · 2018-02-21T14:43:49Z

we should not change 3rd party code

I agree. We will ask the "STM32Cube team" to take into account these typos. Thanks @bmcdonnell-ionx

bmcdonnell-ionx · 2018-02-21T14:46:28Z

@bcostm,

We will ask the "STM32Cube team" to take into account these typos.

Does that account for all of the external code that I modified?

bcostm · 2018-02-21T14:53:13Z

Please do not change files placed in targets/TARGET_STM/*/device/* folders and also other vendors specific files. See the list given by @0xc0170 above. Thanks!

bmcdonnell-ionx · 2018-02-22T00:17:36Z

For reference, the changes I reverted are in these folders, in case you want to try to push any of them upstream.

features/FEATURE_BLE/
features/FEATURE_LWIP/
features/filesystem/fat/ChaN/ff.cpp
features/lorawan/
features/mbedtls/
features/nanostack/
features/unsupported/USBDevice/
features/unsupported/tests/libs/SPIHalfDuplex/
targets/

AnotherButler

Great catches 👍

cmonr · 2018-03-06T03:44:46Z

/morph build

cmonr · 2018-03-06T03:45:10Z

@studavekar This one worked.

mbed-ci · 2018-03-06T04:15:29Z

Build : SUCCESS

Build number : 1350
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-06T06:34:02Z

Exporter Build : FAILURE

Build number : 1004
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6149/

mbed-ci · 2018-03-06T08:28:47Z

Test : FAILURE

Build number : 1132
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6149/1132

bmcdonnell-ionx · 2018-03-06T15:30:06Z

Can someone interpret those CI failure for me? Is there something else I need to change?

bmcdonnell-ionx · 2018-03-07T01:32:14Z

I'll assume the latest and any subsequent CI failures are unrelated to my changes, unless someone tells me otherwise.

cmonr · 2018-03-07T02:51:56Z

/morph mbed2-build

cmonr · 2018-03-07T02:53:10Z

@bmcdonnell-ionx Buy a lotto ticket, you've hit the test bug 2/2 times!

/morph test

cmonr · 2018-03-07T02:54:00Z

Since it seems that morph is now listening to me, going to relaunch the exporter build to get an all-green.
/morph export-build

cmonr · 2018-03-07T02:58:20Z

/morph export-build

mbed-ci · 2018-03-07T12:17:04Z

Test : SUCCESS

Build number : 1155
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6149/1155

0xc0170 · 2018-03-07T13:24:56Z

/morph export-build

mbed-ci · 2018-03-07T14:32:01Z

Exporter Build : SUCCESS

Build number : 1033
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6149/

0xc0170 · 2018-03-08T08:37:44Z

/morph mbed2-build

0xc0170 · 2018-03-08T16:47:30Z

targets/TARGET_NXP/TARGET_LPC408X/device/system_LPC407x_8x_177x_8x.c

@@ -555,7 +555,8 @@ fpu_init();
  LPC_SC->CLKOUTCFG = CLKOUTCFG_Val;    /* Clock Output Configuration         */
 #endif

-  LPC_SC->PBOOST 	|= 0x03;			/* Power Boost control				*/
+  //TODO: verify correct operation w/ this setting. Refer to Table 18 in UM10562.pdf.


How this line got in? Was it bad rebase? I don't see this todo. And this PR was updated not to change targets/ code ?

Good catch; my mistake - sorry! That's from unrelated work, which was not meant to be published.

I added a 4th commit, to undo the bad part from the 3rd commit. Should I squash the 4th into the 3rd?

0xc0170 · 2018-03-09T11:06:23Z

/morph build

mbed-ci · 2018-03-09T11:25:04Z

Build : SUCCESS

Build number : 1398
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6149/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-09T15:28:30Z

Exporter Build : SUCCESS

Build number : 1051
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6149/

mbed-ci · 2018-03-09T18:22:11Z

Test : SUCCESS

Build number : 1186
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6149/1186

studavekar · 2018-03-09T18:23:23Z

/morph mbed2-build

jeromecoutant · 2018-03-15T10:43:28Z

Hi

We reviewed the changed files , we should not change 3rd party code

ST internal ticket to correct typos is opened.

Thx

typos

c4f10aa

a few grammar corrections

085c045

0xc0170 requested a review from AnotherButler February 21, 2018 08:14

0xc0170 changed the title ~~typos~~ Fix typos in the files Feb 21, 2018

0xc0170 reviewed Feb 21, 2018

View reviewed changes

0xc0170 added the needs: review label Feb 21, 2018

0xc0170 added needs: work and removed needs: review labels Feb 21, 2018

revert typos in external sources

7094e13

0xc0170 approved these changes Feb 22, 2018

View reviewed changes

0xc0170 added needs: review and removed needs: work labels Feb 22, 2018

AnotherButler previously approved these changes Mar 1, 2018

View reviewed changes

cmonr added the needs: CI label Mar 6, 2018

0xc0170 added ready for merge and removed needs: CI labels Mar 8, 2018

0xc0170 requested changes Mar 8, 2018

View reviewed changes

0xc0170 added needs: work and removed ready for merge labels Mar 8, 2018

revert accidentally-included change from 7094e13

4a564ec

bmcdonnell-ionx dismissed AnotherButler’s stale review via 4a564ec March 8, 2018 16:57

0xc0170 approved these changes Mar 9, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Mar 9, 2018

0xc0170 added ready for merge and removed needs: CI labels Mar 12, 2018

cmonr added the release-version: 5.8.1 label Mar 12, 2018

cmonr merged commit 9cac3b2 into ARMmbed:master Mar 15, 2018

cmonr removed the ready for merge label Mar 15, 2018

Fix typos in the files #6149

Fix typos in the files #6149

Uh oh!

Conversation

bmcdonnell-ionx commented Feb 21, 2018

Description

Status

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

0xc0170 commented Feb 21, 2018

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Feb 21, 2018

Triggering tests

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

mbed-ci commented Feb 21, 2018

Uh oh!

0xc0170 commented Feb 21, 2018

Uh oh!

bcostm commented Feb 21, 2018

Uh oh!

bmcdonnell-ionx commented Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcostm commented Feb 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmcdonnell-ionx commented Feb 22, 2018

Uh oh!

AnotherButler left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 6, 2018

Uh oh!

cmonr commented Mar 6, 2018

Uh oh!

mbed-ci commented Mar 6, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 6, 2018

Uh oh!

mbed-ci commented Mar 6, 2018

Uh oh!

bmcdonnell-ionx commented Mar 6, 2018

Uh oh!

bmcdonnell-ionx commented Mar 7, 2018

Uh oh!

cmonr commented Mar 7, 2018

Uh oh!

cmonr commented Mar 7, 2018

Uh oh!

cmonr commented Mar 7, 2018

Uh oh!

cmonr commented Mar 7, 2018

Uh oh!

mbed-ci commented Mar 7, 2018

Uh oh!

0xc0170 commented Mar 7, 2018

Uh oh!

mbed-ci commented Mar 7, 2018

Uh oh!

0xc0170 commented Mar 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bmcdonnell-ionx Mar 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Mar 9, 2018

Uh oh!

mbed-ci commented Mar 9, 2018

Triggering tests

bmcdonnell-ionx commented Feb 21, 2018 •

edited

Loading

bcostm commented Feb 21, 2018 •

edited

Loading

bmcdonnell-ionx Mar 8, 2018 •

edited

Loading