Adding Laird BL652 as new target #6164
Conversation
| @@ -0,0 +1,23 @@ | |||
| // The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches. | |||
There was a problem hiding this comment.
Is this comment suppose to be here?
There was a problem hiding this comment.
I feel so as the features section is used on the MCU level. Not specifically used for any of the modules (so far).. but may be required in the future??
There was a problem hiding this comment.
Alright, that's fine with me then.
Just seemed odd to see something before the license header.
targets/targets.json
Outdated
| }, | ||
| "overrides": { | ||
| "lf_clock_src": "NRF_LF_SRC_RC", | ||
| "uart_hwfc": 0 |
There was a problem hiding this comment.
Minor nit. Mind fixing this indentation?
|
@0xc0170 Think you could also give a quick look-over? |
|
@screamerbg @chris-styles Ping for review. |
| @@ -0,0 +1,23 @@ | |||
| // The 'features' section in 'target.json' is now used to create the device's hardware preprocessor switches. | |||
There was a problem hiding this comment.
Alright, that's fine with me then.
Just seemed odd to see something before the license header.
|
@marcuschangarm Wondering if you could take a quick look, particularly with target.json. |
|
/morph build |
Build : SUCCESSBuild number : 1375 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1028 |
Test : SUCCESSBuild number : 1157 |
| "usb_rx": { | ||
| "help": "Value SIO_08", | ||
| "value": "SIO_8" | ||
| } |
There was a problem hiding this comment.
What are usb_tx and usb_rx being used for?
There was a problem hiding this comment.
@marcuschangarm ..they are used for the DAPLink .. https://github.com/ARMmbed/mbed-os/pull/6164/files#diff-67ec7d72556342b67f0cb5b4abfe4516R200
There was a problem hiding this comment.
But none of our code base uses the USB_RX configuration flag. It looks like dead code.
There was a problem hiding this comment.
Isn't USB_TX and USB_RX standardised pins to be defined as part of DAPLink pins in the pin defines? along with BUTTON and LED's..?
There was a problem hiding this comment.
STDIO_UART_TX and STDIO_UART_RX are the only pins being used.
https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_retarget.cpp#L220
There was a problem hiding this comment.
Ah, I see.. good to know. I'll create a different PR to optimise this target then. Thanks!
There was a problem hiding this comment.
I wouldn't worry about it to be honest! 😄 We are very close to merging the NRF52 feature branch anyway and we'll be cleaning up all the NRF52 based targets at that point!
| }, | ||
| "overrides": { | ||
| "lf_clock_src": "NRF_LF_SRC_RC", | ||
| "uart_hwfc": 0 |
There was a problem hiding this comment.
What firmware is the board running on the interface chip?
There was a problem hiding this comment.
DAPLink ..the MTB is running DAPLink ..the MCB (with the BL652 module) communicates over USB via the MTB..
There was a problem hiding this comment.
Right, but which one? Do you know if they have flow control enabled like on the Nordic boards?
There was a problem hiding this comment.
You mean which DAPLink version (if yes, then there isn't one that's released yet!) We got a custom build from @c1728p9 . Regarding flow control, it's enabled in the parent target by default. I had to disable it for this module. With it enabled (default), I wasn't seeing any printf's coming out of the UART..
There was a problem hiding this comment.
Ok, good to know! Some Daplinks require flow control to enabled, some doesn't.
0xc0170
added
release-version: 5.7.7
release-version: 5.8.1
and removed
needs: review
labels
Description
Adding Laird BL652 as a new target.
Pull request type
Greentea: all tests passing. Logs attached below.
GT_log_ARMCC_Pass.txt
GT_log_GCC_Pass.txt
GT_log_IAR_Pass.txt
cc @screamerbg @chris-styles @0xc0170