Skip to content

Fix max32625mbed #6202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from Mar 7, 2018
Merged

Fix max32625mbed #6202

merged 6 commits into from Mar 7, 2018

Conversation

khariya
Copy link
Contributor

@khariya khariya commented Feb 24, 2018 •
edited by adbridge
Loading

MAX32625: Fix serial interrupts and I2C master; Improve SPI block write, us ticker performance, ADC functionality

Description

Fix problems with missing serial objects for interrupts.
Remove automatic stop signaling after read transaction to allow repeated start after read.
Improve SPI block write by replacing byte write loop with hardware assisted block transaction.
Improve performance of us ticker.
Increase analog input range by 2x.

Tested all supported toolchains with MAX32625MBED.

Pull request type

  • Fix
  • Refactor
  • New Target
  • Feature

Keyur Hariya added 5 commits February 23, 2018 16:25
Fix missing serial object for interrupts
8d778d5 
Save serial objects when setting interrupt requests.
Improve uart interrupt handler.
Improve SPI block write
80b0ae0 
Replace looping construct with actual block writes.
Improve us ticker performance
992c889 
Improves accuracy during heavy work load.
Enable ADC scaling and enable internal channels
dcf3b90 
Increases input range by 2x(now, 0-2.4v)
Remove automatic I2C stop after each read
e6d901a 
Automatic stop prevents sending repeated start.
0xc0170
0xc0170 previously requested changes Feb 26, 2018
View reviewed changes
targets/TARGET_Maxim/TARGET_MAX32625/spi_api.c Outdated
}
}
__enable_irq();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace these with critical section enter/exit?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 26, 2018 •
edited
Loading

@khariya Thanks for the fixes, they look good. Just one request regarding using critical section.

@cmonr cmonr dismissed 0xc0170’s stale review February 27, 2018 05:32

PR update addressed comment.

cmonr
cmonr approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like all of the small changes.

In the future, it would help us if the larger bug fixes could be split into their own PR (referring to the SPI write API update)

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

/morph build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : FAILURE

Build number : 1272
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6202/

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1278
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6202/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Test : SUCCESS

Build number : 1071
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6202/1071

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Exporter Build : FAILURE

Build number : 944
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6202/

@cmonr
Copy link
Contributor

cmonr commented Feb 27, 2018

Using this build failure to debug current CI issues. Will kick off rebuild once stable again.

@adbridge
Copy link
Contributor

@cmonr can this one be kicked off again ?

@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2018

Kick.

/morph build

@cmonr
Copy link
Contributor

cmonr commented Mar 1, 2018

/morph build

2 similar comments
@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1340
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6202/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Exporter Build : SUCCESS

Build number : 996
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6202/

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Test : SUCCESS

Build number : 1123
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6202/1123

@studavekar
Copy link
Contributor

/morph mbed2-build

@cmonr cmonr merged commit 2e69ddd into ARMmbed:master Mar 7, 2018
@khariya khariya deleted the fix-max32625mbed branch March 7, 2018 15:37
@khariya khariya restored the fix-max32625mbed branch March 7, 2018 15:38
@khariya khariya deleted the fix-max32625mbed branch March 10, 2018 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.7.7 release-version: 5.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khariya @0xc0170 @cmonr @mbed-ci @adbridge @studavekar