Skip to content

[feature-nrf528xx] Upgrade NRF52 BLE API to version 5 #6220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2018
Merged

[feature-nrf528xx] Upgrade NRF52 BLE API to version 5 #6220

merged 2 commits into from
Mar 6, 2018

Conversation

marcuschangarm
Copy link
Contributor

  • Add NRF_SD_BLE_API_VERSION=5 macro to MCU_NRF52832 target
  • Added initial Softdevice v5 API support for nRF5XPalGattClient.cpp
  • Added initial Softdevice v5 API support for nRF5xGap.h
  • Added initial Softdevice v5 API support for nRF5xGattServer.cpp
  • Make sure the ah() hash function used by the security manager is declared with C linkage
  • Removed 'ARM porting pending' checks in Nordic SDK
  • Added BLE configuration to mbed_lib.json for NRF52x targets
  • Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in btle.cpp; adopted polling dispatch model
  • Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in nRF5xn.cpp
  • Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in nRF5xGap.cpp
  • Added const qualifier to hwCallbacks's p_ble_evt parameter in nRF5xGattServer
  • Add workaround to enable Radio Notification module from Nordic SDK
    • Disabled SWI1 interrupt manually from SWI driver module
      • Added missing include directive for "nrf_nvic.h" in ble_radio_notification.c
  • Set correct number of custom UUIDs
  • Adjust Softdevice RAM requirements for NRF52832/S132
    • RAM settings for the application were adjusted as follow:
      • Start: 0x20003800
      • Size: 0xC800
  • Adjust Softdevice RAM requirements for NRF52840/S140
    • RAM settings for the application were adjusted as follow:
      • Start: 0x20003700 (was 0x20003000)
      • Size: 0xC900
  • Added 3dBm as a permitted TX Power value for NRF52832
  • Fix address type recovery in GAP
  • Return min non-connectable adv interval compatible with infrastrcture's expectations
  • Moved BLE driver from TARGET_SDK_14_2/FEATURE_BLE to TARGET_SDK_14_2/TARGET_SOFTDEVICE_COMMON/ble

Upgrade NRF52 BLE API to version 5
d3a1497 
* Add NRF_SD_BLE_API_VERSION=5 macro to MCU_NRF52832 target
* Added initial Softdevice v5 API support for nRF5XPalGattClient.cpp
* Added initial Softdevice v5 API support for nRF5xGap.h
* Added initial Softdevice v5 API support for nRF5xGattServer.cpp
* Make sure the ah() hash function used by the security manager is declared with C linkage
* Removed 'ARM porting pending' checks in Nordic SDK
* Added BLE configuration to mbed_lib.json for NRF52x targets
* Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in btle.cpp; adopted polling dispatch model
* Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in nRF5xn.cpp
* Migrated APIs and events model for Nordic SDK14.2 & SD API v5 in nRF5xGap.cpp
* Added const qualifier to hwCallbacks's p_ble_evt parameter in nRF5xGattServer
* Add workaround to enable Radio Notification module from Nordic SDK
  * Disabled SWI1 interrupt manually from SWI driver module
    * Added missing include directive for "nrf_nvic.h" in ble_radio_notification.c
* Set correct number of custom UUIDs
* Adjust Softdevice RAM requirements for NRF52832/S132
  * RAM settings for the application were adjusted as follow:
    * Start: 0x20003800
    * Size: 0xC800
* Adjust Softdevice RAM requirements for NRF52840/S140
  * RAM settings for the application were adjusted as follow:
    * Start: 0x20003700 (was 0x20003000)
    * Size: 0xC900
* Added 3dBm as a permitted TX Power value for NRF52832
* Fix address type recovery in GAP
* Return min non-connectable adv interval compatible with infrastrcture's expectations
* Moved BLE driver from TARGET_SDK_14_2/FEATURE_BLE to TARGET_SDK_14_2/TARGET_SOFTDEVICE_COMMON/ble
@marcuschangarm marcuschangarm changed the title Upgrade NRF52 BLE API to version 5 [feature-nrf528xx] Upgrade NRF52 BLE API to version 5 Feb 26, 2018
@marcuschangarm
Copy link
Contributor Author

@donatieng

@cmonr cmonr requested a review from donatieng February 27, 2018 05:08
donatieng
donatieng approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@donatieng donatieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go from my point of view. BLE tests pass on both targeted platforms (NRF52-DK and NRF52840-PDK)

@cmonr
Copy link
Contributor

cmonr commented Mar 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2018

Build : SUCCESS

Build number : 1325
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6220/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2018

Test : FAILURE

Build number : 1109
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6220/1109

@mbed-ci
Copy link

mbed-ci commented Mar 2, 2018

Exporter Build : SUCCESS

Build number : 985
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6220/

@marcuschangarm
Copy link
Contributor Author

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 3, 2018

Test : FAILURE

Build number : 1112
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6220/1112

@cmonr
Copy link
Contributor

cmonr commented Mar 3, 2018

Fingers crossed, third time's the charm.
/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 3, 2018

Test : SUCCESS

Build number : 1113
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6220/1113

@marcuschangarm
Copy link
Contributor Author

Looks like it is time to rebase with the flash-test-fix! 😄

@ghost
Copy link

ghost commented Mar 4, 2018 •
edited by ghost
Loading

@marcuschangarm : can you apply the change from this one as well? #6115 . This only occurs with c++11, so i can see why this wouldn't show up in the current tests.

NRF52 BLE: Fix GCC C++11 include error
9f2fd05 
Change <memory> include to <new>

From: d001fb1
@marcuschangarm
Copy link
Contributor Author

Added #6115 to PR.

@marcuschangarm
Copy link
Contributor Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1342
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6220/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Exporter Build : SUCCESS

Build number : 998
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6220/

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

Test : SUCCESS

Build number : 1125
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6220/1125

@cmonr cmonr merged commit 5475b78 into ARMmbed:feature-nrf528xx Mar 6, 2018
@marcuschangarm marcuschangarm deleted the feature-ble branch March 6, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donatieng donatieng donatieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@marcuschangarm @cmonr @mbed-ci @donatieng @0xc0170