Skip to content

[feature-nrf528xx] Update analogin_api.c for NRF52 SDK 14.2 #6223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2018
Merged

[feature-nrf528xx] Update analogin_api.c for NRF52 SDK 14.2 #6223

merged 1 commit into from
Feb 28, 2018

Conversation

marcuschangarm
Copy link
Contributor

Use new SDK API and fixed return value to be normalized to 16 bit as per the Mbed HAL specification.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 27, 2018

/morph build

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we adding doxygen docs to implementation (analogin HAL has it defined already, duplication not needed)

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : FAILURE

Build number : 1274
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6223/

@marcuschangarm
Copy link
Contributor Author

Why are we adding doxygen docs to implementation (analogin HAL has it defined already, duplication not needed)

For consistency. It would be weird to have comments on the internal functions in the implementation and not all of them.

Use new SDK API and fixed return value to be normalized to 16 bit
as per the Mbed HAL specification.
@marcuschangarm
Copy link
Contributor Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

Build : SUCCESS

Build number : 1287
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6223/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 27, 2018

@cmonr cmonr merged commit f2dd38f into ARMmbed:feature-nrf528xx Feb 28, 2018
@cmonr cmonr removed the needs: work label Feb 28, 2018
@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2018

@0xc0170 I merged this in to keep things rolling, and its only targeting a feature branch.

@marcuschangarm will update the comment to remove the duplicate doxygen in a future PR.

@marcuschangarm marcuschangarm deleted the fix-adc branch April 5, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants