Fix a bug using ELF as output extension #6229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When overriding the OUTPUT_EXT variable in compilation configuration, bugs appear: * The bin variable is not None as the 'elf' string is not interned. * When that is fixed, the function returns None instead of returning the path of the ELF file. Signed-off-by: Hugues de Valon <[email protected]>
|
/morph build |
Build : SUCCESSBuild number : 1283 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 948 |
Test : SUCCESSBuild number : 1074 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When overriding the OUTPUT_EXT variable in compilation configuration,
bugs appear:
path of the ELF file.
The bug fix in this pull request is needed to make the changes of the pull request #6168 work.
@theotherjimmy