Add system_reset call #6230
Add system_reset call #6230
Conversation
platform/mbed_sleep.h
Outdated
| * @return true if a target can go to deepsleep, false otherwise | ||
| */ | ||
| bool sleep_manager_can_deep_sleep(void); | ||
| #warning mbed_sleep.h has been replaced by mbed_power_mgmt.h, please update to mbed_power_mgmt.h [since mbed-os-5.9] |
There was a problem hiding this comment.
Just wanted to mention that I like how early this PR is 👍
platform/sleep.h
Outdated
| @@ -18,7 +18,7 @@ | |||
| #ifndef MBED_OLD_SLEEP_H | |||
| #define MBED_OLD_SLEEP_H | |||
|
|
|||
| #warning sleep.h has been replaced by mbed_sleep.h, please update to mbed_sleep.h [since mbed-os-5.3] | |||
| #include "platform/mbed_sleep.h" | |||
| #warning sleep.h has been replaced by mbed_power_mgmt.h, please update to mbed_power_mgmt.h [since mbed-os-5.3] | |||
There was a problem hiding this comment.
Is this suppose to say since mbed-os-5.9? Or is this because sleep came before mbed_sleep?
bulislaw
force-pushed
the
system_reset
branch
3 times, most recently
from
59cdbd9 to
5782a0f
Compare
|
@cmonr I've updated the warnings to 5.8 as the PR is marked for 5.8-rc1 |
|
@bulislaw looks like this is also going to need a rebase. You may need to chase @SenRamakri for the review as @0xc0170 is out the rest of this week. Is there anyone else that could review? It is starting to get very close to not making it into 5.8.... |
bulislaw
force-pushed
the
system_reset
branch
from
5782a0f to
73b0546
Compare
|
@bulislaw Looks like there's still one lingering travis issue. Once it's all green, we can start the CI build. |
|
@cmonr @SenRamakri I've removed conflicting (and identical) system_reset implementation from ATMEL. |
|
@bulislaw I like that the removed code was completely identical. /morph build |
Build : SUCCESSBuild number : 1307 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 967 |
Test : SUCCESSBuild number : 1091 |
|
@SenRamakri Please re-review and confirm you are happy with the changes |
ghost
mentioned this pull request
Description
Pull request type