C030 platform I2C initialisation fix #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the object to be set up) and zero the I2C object before giving it to i2c_init() as i2_init() has to set up a default frequency for its timeouts to work and it will only do this if the hz field in the object was zero to begin with (otherwise you end up with a random but usually very large indeed timeout).
0xc0170
approved these changes
Mar 5, 2018
|
/morph build |
Build : SUCCESSBuild number : 1330 Triggering tests/morph test |
Test : FAILUREBuild number : 1115 |
Exporter Build : SUCCESSBuild number : 989 |
|
@RobMeades The failure is not related, have not seen it today but keep watching. I noticed the branch is behind master now (does it include PR #6225?) /morph test |
|
Lets wait for the test to be finished |
Test : SUCCESSBuild number : 1116 |
cmonr
added
needs: CI
release-version: 5.7.7
release-version: 5.8.1
and removed
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In pull request #6117 a better mechanism for the I2C initialisation that is required for all C030 platforms was introduced. However, there was a bug in that mechanism which, depending on an uninitialised stack variable, could result in a failure to boot. This PR fixes that bug.
In
set_minimum_battery_voltage()change the order of initialisation so thati2c_init()is called beforei2c_frequency()asi2c_frequency()requires a valid I2C object. Zero the I2C object sincei2c_init()has to set a default frequency for its timeouts to work and it will only do that if thehzfield of the object was zero to begin with.All platform tests pass reliably after this change.
C030_U201_Mbed_Tests_Logs.txt
Pull request type