Allow build profiles to omit language entries #6271
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow toolchain build profiles to omit language entries
Description
Currently the
prepare_toolchain
function inbuild_api.py
expects all profiles to contain all language keys. When writing a toolchain profile to overlay on the default profiles this can cause unexpected behaviour: ie. if you don't have an entry for the key there is an opaque error.The workaround is to have a profile.json file that looks like this:
but it would be nice to allow this
This pull request allows this by modifying the code that gets the language key from the dictionary.
Pull request type