-
Notifications
You must be signed in to change notification settings - Fork 3k
Support for nRF52x BLE 4.2 and 5 events #6308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can confirm that this fixes connection timeout issues I was seeing on the feature-nrf528xx branch. Related forum post: |
I believe this is a fix, not a feature (targeting patch release). /morph build |
Thanks @AGlass0fMilk for testing :) @0xc0170 more like a fixture ;) - feature enabling a fix? Is that a thing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
At some point we will need APIs that exposes these events allows user code to handle them.
Build : SUCCESSBuild number : 1394 Triggering tests/morph test |
uint8_t const data_length_peer = | ||
p_gap_evt->params.data_length_update_request.peer_params.max_tx_octets; | ||
|
||
const uint8_t max_data_length = NRF_SDH_BLE_GATT_MAX_MTU_SIZE + 4 /* L2CAP header size */; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The L2CAP header size is defined with L2CAP_HDR_LEN
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is defined in nrf_ble_gatt.c
in the Nordic SDK so not available in that scope, that's why I put it like that.
Test : SUCCESSBuild number : 1182 |
Exporter Build : SUCCESSBuild number : 1048 |
Description
This pull requests adds handling of 3 BLE 4.2 & 5 events generated by the NRF S132 and S140 softdevices:
It fixes issues encountered when using a device (phone, etc) issuing these requests to the Nordic stack that will issue these events that need to be handled by the application for a connection to be established successfully.
Pull request type