Skip to content

Add missing Doxygen descriptions for Nanostack #6313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

  • Add missing Doxygen descriptions for Nanostack and Mesh-API files.
  • Enable building of Doxygen documentation for Nanostack related headers.

0xc0170
0xc0170 previously approved these changes Mar 9, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

@SeppoTakalo Please review travis docs failure

@cmonr
Copy link
Contributor

cmonr commented Mar 19, 2018

@SeppoTakalo Any update on the Travis doc failures?

@AnotherButler Ping for review.

AnotherButler
AnotherButler previously approved these changes Mar 19, 2018
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want @SenRamakri to confirm the Doxyfile options are right.

Fix couple of parameter issues as well.
@SeppoTakalo
Copy link
Contributor Author

Fixed couple of remaining Doxygen warnings from Mesh API.

@0xc0170 0xc0170 requested a review from SenRamakri March 21, 2018 13:25
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2018

You may want @SenRamakri to confirm the Doxyfile options are right.

Done, added as a reviewer.

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2018

Build : SUCCESS

Build number : 1513
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6313/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 21, 2018

13:15:45 FATAL: command execution failed
13:15:45 java.io.EOFException

. . .
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 22, 2018

No obvious errors.

Relaunching.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2018

@SeppoTakalo
Copy link
Contributor Author

@AnotherButler I did some changes after your last review, so the status is now lost. Please re-review.

Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@studavekar
Copy link
Contributor

Looks like tests are not triggered. re-triggering

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

@SeppoTakalo
Copy link
Contributor Author

tests-mbed_drivers-lp_timeout failed. Please restart tests.

@studavekar
Copy link
Contributor

studavekar commented Mar 26, 2018

tests-mbed_drivers-lp_timeout failed. Please restart tests

@0xc0170 what is you're suggestion looks like unstable test from the console logs tests-mbed_drivers-lp_timeout failed at different point full logs

00:27:03.630 [1522043312.83][CONN][INF] found KV pair in stream: {{__testcase_finish;Callback override (attach_us);1;0}}, queued...
00:27:03.728 [1522043312.93][CONN][RXD] >>> Running case #7: 'Multiple timeouts running in parallel (attach)'...
00:27:03.829 [1522043313.03][CONN][RXD] :181::FAIL: Expected 16 Was 15
00:27:33.057 [1522043342.26][CONN][INF] found KV pair in stream: {{__testcase_finish;Callback override (attach_us);1;0}}, queued...
00:27:33.149 [1522043342.35][CONN][RXD] >>> Running case #7: 'Multiple timeouts running in parallel (attach)'...
00:27:33.250 [1522043342.45][CONN][RXD] :181::FAIL: Expected 16 Was 15
00:28:44.948 [1522043414.15][HTST][INF] Test inconclusive due to transport delay, retrying
00:28:45.114 [1522043414.30][CONN][RXD] :412::FAIL: Expected 'pass' Was 'fail'. Host script reported a failure
00:28:45.114 [1522043414.30][CONN][INF] found KV pair in stream: {{__testcase_finish;Timing drift (attach_us);0;1}}, queued...
00:28:45.203 [1522043414.40][CONN][RXD] >>> 'Timing drift (attach_us)': 0 passed, 1 failed with reason 'Assertion Failed'
00:28:45.203 [1522043414.40][CONN][RXD]
00:28:45.305 [1522043414.50][CONN][RXD] >>> Test cases: 21 passed, 1 failed with reason 'Assertion Failed'
00:28:45.305 [1522043414.51][CONN][RXD] >>> TESTS FAILED!
00:29:11.988 [1522043441.19][CONN][INF] found KV pair in stream: {{__testcase_name;Timing drift (attach_us)}}, queued...
00:29:12.087 [1522043441.29][CONN][RXD] :85::FAIL: Expected 1 Was 0

Re-triggering test

/morph test

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2018

@0xc0170 what is you're suggestion looks like unstable test from the console logs tests-mbed_drivers-lp_timeout failed at different point full logs

@ARMmbed/team-st-mcd Can you review this failure ? There was similar failures previously that were resolved

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

@cmonr cmonr merged commit 2673758 into ARMmbed:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants