Skip to content

MIMXRT: define PullUp default value #6328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2018
Merged

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 12, 2018

Description

This target defines few PullUp values, one should be defined to be PullUp that
an application can use. We use the same value as PullDefault

@ARMmbed/team-nxp Please review

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

This target defines few PullUp values, one should be defined to be PullUp that
an application can use. We use the same value as PullDefault
@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 12, 2018

This unblocks #6304

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 12, 2018

/morph build

@adbridge
Copy link
Contributor

Because this is needed for #6304 which in turn is needed for 5.8-rc2 we can take this without review from the NXP team. At the moment there just needs to be a value defined. The specific value can always be patched in 5.8.1 if necessary.

@adbridge adbridge self-requested a review March 12, 2018 10:25
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

Build : SUCCESS

Build number : 1415
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6328/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 12, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 12, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

K64F devices timed out. Will restart test in a bit.

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

/morph test

@maclobdell
Copy link
Contributor

cc @mmahadevan108

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

Flash cache test issue came up...

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 12, 2018

@cmonr cmonr removed the needs: CI label Mar 12, 2018
@cmonr cmonr merged commit 205b2ed into ARMmbed:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants