Skip to content

Corrected lwip adaptation TCP flagging #6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2018
Merged

Corrected lwip adaptation TCP flagging #6333

merged 1 commit into from
Mar 20, 2018

Conversation

mikaleppanen
Copy link

Description

Corrected LWIP TCP flagging. Some TCP code was not flagged which caused compilation error in UDP only configuration.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@0xc0170 0xc0170 requested a review from kjbracey March 12, 2018 14:32
kjbracey
kjbracey reviewed Mar 13, 2018
View reviewed changes
features/FEATURE_LWIP/lwip-interface/lwip_stack.c Outdated
@@ -1147,9 +1147,11 @@ static nsapi_error_t mbed_lwip_socket_listen(nsapi_stack_t *stack, nsapi_socket_
{
struct lwip_socket *s = (struct lwip_socket *)handle;

#if LWIP_TCP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To further reduce code size, I reckon the entirety of both these functions probably should be wrapped in the #if so they just return "unsupported" if !TCP.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated flagging.

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

Build : SUCCESS

Build number : 1439
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6333/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

Exporter Build : FAILURE

Build number : 1085
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6333/

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

Test : FAILURE

Build number : 1219
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6333/1219

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

CI issue: NRF52 flash cache test

/morph test

@cmonr
Copy link
Contributor

cmonr commented Mar 16, 2018

CI issue: ARM network licenses could not be checked out during build.

Restarting.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

Exporter Build : SUCCESS

Build number : 1114
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6333/

@mbed-ci
Copy link

mbed-ci commented Mar 17, 2018

Test : FAILURE

Build number : 1245
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6333/1245

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 19, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Mar 19, 2018

Test : SUCCESS

Build number : 1257
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6333/1257

@cmonr cmonr merged commit 0b7a9a9 into ARMmbed:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikaleppanen @cmonr @mbed-ci @0xc0170 @kjbracey