Add Kinetis USB Phy #6337

c1728p9 · 2018-03-12T20:33:04Z

Add Kinetis USBPhy
Add extra checks to USBDevice
Fix read_start behavior when configuring

c1728p9 · 2018-03-12T20:34:16Z

Please review @maciejbocianski and @fkjagodzinski

ashok-rao

Changes LGTM!..would be nice to know how to unit test these..!

maciejbocianski · 2018-03-13T14:49:27Z

targets/TARGET_Freescale/usb/USBPhy_Kinetis.cpp

+    NVIC_EnableIRQ(USB0_IRQn);
+}
+
+void USBPhyHw::deinit()


shouldn't we add disconnecting code here (similar to LPC176X implementation)?
without it, re-initialization is failing

Good catch. It has been added.

Copy the Kinetis USB driver files from mbed-os\features\unsupported\USBDevice\targets\TARGET_Freescale and update them to match the new USBPhy API.

Assert that when a callback is completed it is the active callback.

Remove the USBDevice function read_start and automatically start all reads internally in USBDevice. This patch also renames the function read_finish to read.

c1728p9 · 2018-03-14T23:52:02Z

@ashok-rao the USB device HAL specification explains how to run the tests:

mbed test -t <toolchain> -m <target> -n mbed-os-tests-usb_device-*

c1728p9 · 2018-03-14T23:59:23Z

Addressed @maciejbocianski's comment and also simplified the USBDevice read API (user API not HAL API). The older API allowed reads to be explicitly started, which some hardware doesn't support (Like the LPC1768). With the new API the receiver is automatically started when the endpoint is added.

Old endpoint state machine diagram:

New endpoint state machine diagram:

The USB technology docs PR has also been updated to reflect this.

cmonr · 2018-03-15T03:58:04Z

/morph build

mbed-ci · 2018-03-15T08:16:12Z

Build : FAILURE

Build number : 1449
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6337/

Remove read_start and replace read_finish with read to match the new USBDevice API.

cmonr · 2018-03-15T18:00:04Z

Will relaunch when able to. ARM license CI issue.

cmonr · 2018-03-15T18:50:11Z

/morph build

mbed-ci · 2018-03-15T19:50:42Z

Build : SUCCESS

Build number : 1459
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6337/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-15T23:36:45Z

Exporter Build : SUCCESS

Build number : 1100
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6337/

mbed-ci · 2018-03-15T23:39:28Z

Test : FAILURE

Build number : 1226
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6337/1226

Initialize the _transfer structure so the behavior is the same regardless of prior memory contents. This fixes a hang during USB testing when CI flags are used.

Call USBDevice::endpoint_stall/unstall in the request to set/clear halt so the endpoint state is properly updated in the array _endpoint_info.

cmonr · 2018-03-16T05:01:38Z

CI issue: NRF52 flash cache test

Rebuilding due to new PR commits.
/morph build

mbed-ci · 2018-03-16T06:04:43Z

Build : SUCCESS

Build number : 1462
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6337/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-16T07:47:36Z

Exporter Build : SUCCESS

Build number : 1107
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6337/

mbed-ci · 2018-03-16T13:46:29Z

Test : FAILURE

Build number : 1235
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6337/1235

cmonr · 2018-03-16T16:05:11Z

CI issue: NRF52 flash cache test

Restarting.
/morph test

mbed-ci · 2018-03-16T18:35:25Z

Test : SUCCESS

Build number : 1237
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6337/1237

Add Kinetis USB files

b112449

c1728p9 requested review from ashok-rao and 0xc0170 March 12, 2018 20:34

c1728p9 force-pushed the feature-hal-spec-usb-device branch from 262cddc to a9f94dc Compare March 12, 2018 22:30

cmonr added the needs: review label Mar 12, 2018

0xc0170 approved these changes Mar 13, 2018

View reviewed changes

ashok-rao approved these changes Mar 13, 2018

View reviewed changes

fkjagodzinski approved these changes Mar 13, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 13, 2018

maciejbocianski reviewed Mar 13, 2018

View reviewed changes

c1728p9 added 3 commits March 14, 2018 18:47

Update Kinetis USB to match the USBPhy API

fff58b9

Copy the Kinetis USB driver files from mbed-os\features\unsupported\USBDevice\targets\TARGET_Freescale and update them to match the new USBPhy API.

Add and assert USB callback completion

08c20fc

Assert that when a callback is completed it is the active callback.

Change USBDevice read handling

9feda72

Remove the USBDevice function read_start and automatically start all reads internally in USBDevice. This patch also renames the function read_finish to read.

c1728p9 force-pushed the feature-hal-spec-usb-device branch from a9f94dc to 0c90346 Compare March 14, 2018 23:48

Update USBTester for simplified read handling

1ee2866

Remove read_start and replace read_finish with read to match the new USBDevice API.

c1728p9 force-pushed the feature-hal-spec-usb-device branch from 0c90346 to 1ee2866 Compare March 15, 2018 16:48

c1728p9 and others added 2 commits March 15, 2018 20:04

Fix USB init problems

18cd464

Initialize the _transfer structure so the behavior is the same regardless of prior memory contents. This fixes a hang during USB testing when CI flags are used.

Update stall state on set and clear feature

de19b1d

Call USBDevice::endpoint_stall/unstall in the request to set/clear halt so the endpoint state is properly updated in the array _endpoint_info.

cmonr added ready for merge and removed needs: CI labels Mar 16, 2018

cmonr merged commit 46fe769 into ARMmbed:feature-hal-spec-usb-device Mar 16, 2018

cmonr removed the ready for merge label Mar 16, 2018

Add Kinetis USB Phy #6337

Add Kinetis USB Phy #6337

Uh oh!

Conversation

c1728p9 commented Mar 12, 2018

Uh oh!

c1728p9 commented Mar 12, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

maciejbocianski Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1728p9 commented Mar 14, 2018

Uh oh!

c1728p9 commented Mar 14, 2018

Uh oh!

cmonr commented Mar 15, 2018

Uh oh!

mbed-ci commented Mar 15, 2018

Uh oh!

cmonr commented Mar 15, 2018

Uh oh!

cmonr commented Mar 15, 2018

Uh oh!

mbed-ci commented Mar 15, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 15, 2018

Uh oh!

mbed-ci commented Mar 15, 2018

Uh oh!

cmonr commented Mar 16, 2018

Uh oh!

mbed-ci commented Mar 16, 2018

Triggering tests

Uh oh!

mbed-ci commented Mar 16, 2018

Uh oh!

mbed-ci commented Mar 16, 2018

Uh oh!

cmonr commented Mar 16, 2018

Uh oh!

mbed-ci commented Mar 16, 2018

Uh oh!

Uh oh!

maciejbocianski Mar 13, 2018 •

edited

Loading