Fix PR template

[0xc0170]

Description

Fixing bad markdown choice - PR type is not a task list but just a list of checkboxes

Thanks @bcostm for the report

Pull request type

• Fix
• Refactor
• New target
• Feature
• Breaking change

[adbridge]

LGTM

[cmonr]

Sometimes, kicking off a morph build feels really silly.

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 1445
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6348/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 1222
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6348/1222

[cmonr]

Status wasn't reported.
/morph export-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1103
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6348/

[0xc0170]

/morph mbed2-build

[bcostm]

@0xc0170 are you sure this new lines will display correctly the result, I mean without the progress bar appearing on the PR main page ? Because this morning I tried the same syntax in my PR 6379 (i.e. * [ ] Fix...) and the progress bar was still present.

[cmonr]

@bcostm That PR was missing the * before the [ ] and [x]. I just modified that PR's description, and it now looks like this PR.

[bcostm]

I think we misunderstand each other 😄 With your modification I see this 1 of 5 progress bar:

And this is what I wanted to remove... For me those tasks list (and progress bar) should be kept for good reasons like waiting reviewers approval, tests, etc...

[cmonr]

@bcostm Ah, gotcha. For some reason, I recalled seeing that task bar in the PR and thought I noticed it go away with this syntax...

Anyways, @0xc0170 thoughts? A quick look at the GitHub markdown indicates that using any kind of checkboxes will lead to that progress bar.

https://help.github.com/articles/about-task-lists/

[0xc0170]

Thanks @bcostm for the review, have to revise this 🙄

[0xc0170]

Looking at the checkbox possibility, the only way it's task list that we do not want. Therefore I would revert this to the basic list

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Does not look "fancy" but still keeps the same informative context that is important to us.

[0xc0170]

Rebased, updated

[cmonr]

@bcostm Thoughts?

[bcostm]

Yes it looks fine. Thanks.

[mbed-ci]

Build : SUCCESS

Build number : 1511
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6348/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[adbridge]

I can live with that now as it is :)

[0xc0170]

/morph build

(I aborted the previous build, the code was changed after)

[mbed-ci]

Build : SUCCESS

Build number : 1512
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6348/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 1151
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6348/

[mbed-ci]

Test : SUCCESS

Build number : 1292
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6348/1292