-
Notifications
You must be signed in to change notification settings - Fork 3k
Cellular: update attach test #6350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is worth noting that the reason for this pull request is that, in the case of u-blox modems, if the AT command to put the modem into automatic PLMN selection mode, |
@mudassar-ublox Please update your PR description to follow the template that we provided. An example of how that template is used can be found here: #6264 |
@jarvte will review this |
_at.cmd_start("AT+COPS=0"); | ||
uint8_t len=8; | ||
uint8_t buf[8]; | ||
_at.cmd_start("AT+COPS?"); | ||
_at.cmd_stop(); | ||
_at.resp_start(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could do this also without need to declare buf and doing string compare:
_at.resp_start("+COPS:");
int mode = _at.read_int();
_at.resp_stop();
if (mode != 0) { ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will check and update soon.
/morph build |
Build : SUCCESSBuild number : 1470 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1116 |
Test : FAILUREBuild number : 1247 |
/morph test |
/morph mbed2-build |
1 similar comment
/morph mbed2-build |
Test : FAILUREBuild number : 1259 |
/morph test |
Test : FAILUREBuild number : 1265 |
/morph test |
Test : SUCCESSBuild number : 1271 |
Description
This pull request resolves the problem of test case 'attach' of cellular test suite introduced by ARM.
If AT+COPS=0 is sent and modem is already in automatic selection mode, the modem starts searching for another PLMN (different to that already in use) and takes some time. This is not required if the module is already in automatic selection mode. In this pull request, AT+COPS? is sent first to check if the module is already in automatic selection mode or not. If it is, there is no need for AT+COPS=0, otherwise it is sent and then waits for the module to register.
Pull request type