STM32 LPTICKER : optimize RTC wake up timer init #6370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
previously approved these changes
Mar 15, 2018
marcemmers
reviewed
Mar 15, 2018
targets/TARGET_STM/rtc_api.c
Outdated
| if (HAL_RTCEx_SetWakeUpTimer_IT(&RtcHandle, 0xFFFF & WakeUpCounter, WakeUpClock[DivIndex - 1]) != HAL_OK) { | ||
| error("rtc_set_wake_up_timer init error (%d)\n", DivIndex); | ||
| if (HAL_RTCEx_SetWakeUpTimer_IT(&RtcHandle, (uint32_t)WakeUpCounter, WakeUpClock) != HAL_OK) { | ||
| error("rtc_set_wake_up_timer init error"); |
There was a problem hiding this comment.
Bit of nitpicking but you forgot the '\n' in the error.
Otherwise looks ok!
Division in a while loop is removed
jeromecoutant
force-pushed
the
PR_LPT_RTC_OPTIM
branch
from
281ac85 to
882f331
Compare
cmonr
approved these changes
Mar 19, 2018
|
/morph build |
Build : SUCCESSBuild number : 1482 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1127 |
Test : SUCCESSBuild number : 1267 |
0xc0170
approved these changes
Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Division in a while loop is removed
You can read the study here:
#6272 (comment)
@marcemmers
Pull request type