lwIP: fix some IPv6 errors, eg TCP keepalive #6416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glue code was inspecting lwIP's netconn "type", checking directly for NETCONN_UDP and NETCONN_TCP. Unfortunately the type byte has some flag bits like "IPv6", which means the tests fail if it's an IPv6 socket. So, for example, TCP socket options were rejected for IPv6. Add the necessary NETCONNTYPE_GROUP macros to fix this.
mikaleppanen
approved these changes
Mar 22, 2018
|
/morph build |
Build : SUCCESSBuild number : 1550 Triggering tests/morph test |
Exporter Build : ABORTEDBuild number : 1189 |
Test : SUCCESSBuild number : 1329 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 1194 |
SeppoTakalo
approved these changes
Mar 25, 2018
0xc0170
approved these changes
Mar 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Glue code was inspecting lwIP's netconn
type, checking directly forNETCONN_UDPandNETCONN_TCP.Unfortunately the type byte has some flag bits like "IPv6", which means the tests fail if it's an IPv6 socket. So, for example, TCP socket options were rejected for IPv6.
Add the necessary
NETCONNTYPE_GROUPmacros to fix this.Pull request type