Nuvoton: Fix NVSTORE test failed #6437

ccli8 · 2018-03-23T01:49:36Z

Description

This PR includes a bugfix for NVSTORE test (mbed-os-features-nvstore-tests-nvstore-functionality) failed.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

In Mbed OS, page size is program unit, which is different than FMC definition. After fixing page size, we can pass NVSTORE test (mbed-os-features-nvstore-tests-nvstore-functionality).

ccli8 · 2018-03-23T01:51:49Z

NUC472/ARM

mbedgt: test suite report:
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| target                 | platform_name      | test suite                                           | result | elapsed_time (sec) | copy_method |
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 25.05              | default     |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 18.19              | default     |
| NUMAKER_PFM_NUC472-ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-flash                         | OK     | 18.83              | default     |
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

NUC472/GCC_ARM

mbedgt: test suite report:
+----------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| target                     | platform_name      | test suite                                           | result | elapsed_time (sec) | copy_method |
+----------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 25.47              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 18.25              | default     |
| NUMAKER_PFM_NUC472-GCC_ARM | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-flash                         | OK     | 19.16              | default     |
+----------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

NUC472/IAR

mbedgt: test suite report:
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| target                 | platform_name      | test suite                                           | result | elapsed_time (sec) | copy_method |
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 24.84              | default     |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 17.8               | default     |
| NUMAKER_PFM_NUC472-IAR | NUMAKER_PFM_NUC472 | mbed-os-tests-mbed_hal-flash                         | OK     | 18.7               | default     |
+------------------------+--------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

ccli8 · 2018-03-23T01:53:42Z

M453/ARM

mbedgt: test suite report:
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 23.45              | default     |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 15.91              | default     |
| NUMAKER_PFM_M453-ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-flash                         | OK     | 16.66              | default     |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

M453/GCC_ARM

mbedgt: test suite report:
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target                   | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 23.77              | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 15.6               | default     |
| NUMAKER_PFM_M453-GCC_ARM | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-flash                         | OK     | 16.82              | default     |
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

M453/IAR

mbedgt: test suite report:
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 23.23              | default     |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 15.1               | default     |
| NUMAKER_PFM_M453-IAR | NUMAKER_PFM_M453 | mbed-os-tests-mbed_hal-flash                         | OK     | 16.41              | default     |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

ccli8 · 2018-03-23T01:55:26Z

M487/ARM

mbedgt: test suite report:
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 35.29              | default     |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 24.45              | default     |
| NUMAKER_PFM_M487-ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                         | OK     | 26.96              | default     |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

M487/GCC_ARM

mbedgt: test suite report:
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target                   | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 35.6               | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 25.02              | default     |
| NUMAKER_PFM_M487-GCC_ARM | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                         | OK     | 27.27              | default     |
+--------------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

M487/IAR

mbedgt: test suite report:
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| target               | platform_name    | test suite                                           | result | elapsed_time (sec) | copy_method |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-features-nvstore-tests-nvstore-functionality | OK     | 34.88              | default     |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbed_drivers-flashiap                  | OK     | 24.88              | default     |
| NUMAKER_PFM_M487-IAR | NUMAKER_PFM_M487 | mbed-os-tests-mbed_hal-flash                         | OK     | 26.85              | default     |
+----------------------+------------------+------------------------------------------------------+--------+--------------------+-------------+
mbedgt: test suite results: 3 OK

cmonr

Not sure about this change. Does this mean that in the test, the page_size variable isn't being used to describe the page size of the flash, but sometrhing else?

What's a program unit?

cmonr · 2018-03-23T03:00:32Z

@toyowata, I'm curious. Would you be able to test if this PR fixes the export issue in your PR (#6413) with the ARCH_PRO board and IAR?

ccli8 · 2018-03-23T03:10:11Z

@cmonr @toyowata Per my understanding, page_size means program unit. Take NUMAKER_PFM_M487 as an example, its page_size is set to 4 in this fix, meaning program address/size must be 4byte-aligned.

davidsaada · 2018-03-23T08:11:02Z

I'm not familiar with this hardware, but from the changes, it seems that page size is programmatically reduced from a large size (512B/2KB) to 4 bytes, which is great for any application trying to store anything on the flash like NVStore. This both allows a much larger granularity and reduces memory consumption when allocating a page buffer. Good work.

0xc0170 · 2018-03-23T09:59:26Z

/morph build

mbed-ci · 2018-03-23T11:02:57Z

Build : SUCCESS

Build number : 1539
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6437/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-23T15:08:33Z

Exporter Build : SUCCESS

Build number : 1180
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6437/

mbed-ci · 2018-03-23T16:28:23Z

Test : SUCCESS

Build number : 1320
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6437/1320

[Nuvoton] Fix page size in flash IAP

f0865f8

In Mbed OS, page size is program unit, which is different than FMC definition. After fixing page size, we can pass NVSTORE test (mbed-os-features-nvstore-tests-nvstore-functionality).

cmonr requested a review from davidsaada March 23, 2018 02:56

cmonr added the needs: review label Mar 23, 2018

cmonr reviewed Mar 23, 2018

View reviewed changes

davidsaada approved these changes Mar 23, 2018

View reviewed changes

0xc0170 approved these changes Mar 23, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Mar 23, 2018

0xc0170 added ready for merge and removed needs: CI labels Mar 23, 2018

cmonr added the release-version: 5.8.1 label Mar 23, 2018

cmonr merged commit cffa1c0 into ARMmbed:master Mar 23, 2018

cmonr removed the ready for merge label Mar 23, 2018

ccli8 deleted the nuvoton_fix_flash branch March 26, 2018 01:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Nuvoton: Fix NVSTORE test failed #6437

Nuvoton: Fix NVSTORE test failed #6437

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

cmonr left a comment

Uh oh!

cmonr commented Mar 23, 2018

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

davidsaada commented Mar 23, 2018

Uh oh!

0xc0170 commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Uh oh!

Uh oh!

Nuvoton: Fix NVSTORE test failed #6437

Nuvoton: Fix NVSTORE test failed #6437

Uh oh!

Conversation

ccli8 commented Mar 23, 2018

Description

Pull request type

Uh oh!

ccli8 commented Mar 23, 2018

NUC472/ARM

NUC472/GCC_ARM

NUC472/IAR

Uh oh!

ccli8 commented Mar 23, 2018

M453/ARM

M453/GCC_ARM

M453/IAR

Uh oh!

ccli8 commented Mar 23, 2018

M487/ARM

M487/GCC_ARM

M487/IAR

Uh oh!

cmonr left a comment

Choose a reason for hiding this comment

Uh oh!

cmonr commented Mar 23, 2018

Uh oh!

ccli8 commented Mar 23, 2018

Uh oh!

davidsaada commented Mar 23, 2018

Uh oh!

0xc0170 commented Mar 23, 2018

Uh oh!

mbed-ci commented Mar 23, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Mar 23, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Mar 23, 2018

Test : SUCCESS

Uh oh!

Uh oh!