Skip to content

Update USBTester product name #6439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2018
Merged

Update USBTester product name #6439

merged 1 commit into from
Mar 26, 2018

Conversation

c1728p9
Copy link
Contributor

@c1728p9 c1728p9 commented Mar 23, 2018

Change the name reported by USBTester from CDC DEVICE to MBED TEST DEVICE to make it more recognizable.

@c1728p9 c1728p9 requested review from 0xc0170 and ashok-rao March 23, 2018 13:12
@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 23, 2018

@maciejbocianski

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2018

Build : SUCCESS

Build number : 1543
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6439/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2018

Exporter Build : SUCCESS

Build number : 1183
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6439/

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2018

Test : FAILURE

Build number : 1323
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6439/1323

@studavekar
Copy link
Contributor

studavekar commented Mar 23, 2018 •
edited
Loading

Test : FAILURE
Build number : 1323
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6439/1323

You may need to pull in #6340 on feature branch

@c1728p9 c1728p9 force-pushed the feature-hal-spec-usb-device branch from d16124d to 2a76392 Compare March 24, 2018 14:21
@c1728p9 c1728p9 force-pushed the update_usb_product_name branch from 327337e to b407734 Compare March 24, 2018 14:29
@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 24, 2018

Rebased this and the feature branch

@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Build : FAILURE

Build number : 1560
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6439/

@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Build : FAILURE

Build number : 1562
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6439/

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 24, 2018

Build : SUCCESS

Build number : 1563
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6439/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2018

Exporter Build : SUCCESS

Build number : 1201
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6439/

@mbed-ci
Copy link

mbed-ci commented Mar 25, 2018

Test : SUCCESS

Build number : 1340
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6439/1340

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 26, 2018

I've just restarted https://travis-ci.org/ARMmbed/mbed-os/builds/357383590 - it was green, did not report back the status

maciejbocianski
maciejbocianski reviewed Mar 26, 2018
View reviewed changes
TESTS/usb_device/basic/USBTester.cpp Outdated
@@ -286,9 +286,11 @@ const uint8_t *USBTester::string_iinterface_desc()
const uint8_t *USBTester::string_iproduct_desc()
{
static const uint8_t string_iproduct_descriptor[] = {
0x16,
0x34,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be 0x22

@c1728p9
Update USBTester product name
8f69018 
Change the name reported by USBTester from CDC DEVICE to
MBED TEST DEVICE.
@c1728p9 c1728p9 force-pushed the update_usb_product_name branch from b407734 to 8f69018 Compare March 26, 2018 12:24
@c1728p9
Copy link
Contributor Author

c1728p9 commented Mar 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

Build : SUCCESS

Build number : 1570
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6439/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

Test : SUCCESS

Build number : 1361
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6439/1361

@mbed-ci
Copy link

mbed-ci commented Mar 26, 2018

Exporter Build : SUCCESS

Build number : 1209
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6439/

@cmonr cmonr merged commit c10e081 into ARMmbed:feature-hal-spec-usb-device Mar 26, 2018
@cmonr cmonr removed the needs: CI label Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejbocianski maciejbocianski maciejbocianski left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@ashok-rao ashok-rao Awaiting requested review from ashok-rao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@c1728p9 @0xc0170 @mbed-ci @studavekar @maciejbocianski @cmonr