Skip to content

Q12018 stm32 ustickers #6463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 3, 2018
Merged

Q12018 stm32 ustickers #6463

merged 3 commits into from
Apr 3, 2018

Conversation

LMESTM
Copy link
Contributor

@LMESTM LMESTM commented Mar 26, 2018

Description

This PR contains adaptations to STM32 targets to fit with new HAL tickers specifications.

It benefits from this new specification to also make STM target layer simpler as now the 16 bits vs. 32 bits counter differences are managed in mbed common layer.

Review comments are welcome. First tests results are positive : tested OK on F4, F7, L4 and L0 target so far. More tests results will follow.

This PR also contains a fix in the test that as been sent in parallel also in #6462.
Once #6462 or equivalent fix gets merged, I can rebase this pull request.

Pull request type

[ ] Fix
[x ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@LMESTM LMESTM changed the base branch from master to feature-hal-spec-ticker March 26, 2018 20:08
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 26, 2018

@bulislaw @c1728p9 @0xc0170

@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 26, 2018

Thoughts from workshop ;-) @bcostm @adustm

@cmonr
Copy link
Contributor

cmonr commented Mar 27, 2018

@LMESTM Since the last commit is already in its own PR, would you mind removing it from this PR?

Looking forward to see those test results!

@LMESTM LMESTM force-pushed the Q12018_stm32_ustickers branch from 0271ff6 to 4cfed18 Compare March 27, 2018 07:17
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 27, 2018

@LMESTM Since the last commit is already in its own PR, would you mind removing it from this PR?

@cmonr done

0xc0170
0xc0170 approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It quite simplified implementation (removing targets/TARGET_STM/us_ticker_16b code file)

@0xc0170 0xc0170 requested review from bulislaw and c1728p9 March 27, 2018 07:40
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Build : FAILURE

Build number : 1580
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6463/

@jeromecoutant
Copy link
Collaborator

Maybe we should wait for #6469 ?

@bulislaw bulislaw force-pushed the feature-hal-spec-ticker branch from afd66ab to 6daa7fc Compare March 27, 2018 14:06
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2018

Maybe we should wait for #6469 ?

It's in, please rebase

@LMESTM LMESTM force-pushed the Q12018_stm32_ustickers branch from 4cfed18 to d1945b2 Compare March 27, 2018 16:04
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 27, 2018

@0xc0170 rebased now

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Build : SUCCESS

Build number : 1591
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6463/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 27, 2018

Tests results
ARM TC only
30 STM32 targets
tickers, timers, timeout, hal-ticker, hal-us-ticker tests
3069 us-tickers tests ok

=>us tickers results are OK

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Exporter Build : SUCCESS

Build number : 1228
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6463/

@mbed-ci
Copy link

mbed-ci commented Mar 27, 2018

Test : FAILURE

Build number : 1379
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6463/1379

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2018

@LMESTM What is the failure for F7, can you review? I think it is not related to this change (not using 16bit ticker??) or it is? in any case, might be real failure that is there

@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 30, 2018

Hi
I tested the branch twice here with my NUCLEO_F746ZG on the branch I have
could you restart the test ?

LMESTM added 3 commits March 30, 2018 18:04
@LMESTM
Update STM32 16 bits us_tickers in line with new mbed HAL
3447dd7 
The new HAL allows to share the timer bit width and frequency,
the actual handling of mapping 16 bits counter up to 32 bits or
64 bits is now managed by mbed common layer.

This makes this ticker layer very similar to 32bits one and much
easier than before.
@LMESTM
Make us_ticker common between 16 and 32 bits counters
25a4663
@LMESTM
Activate USTICKER device feature for all STM32 targets
79e6851
@LMESTM
Copy link
Contributor Author

LMESTM commented Mar 30, 2018

  • I rebased to take benefit of fixes on test side, and F7 test confirmed ok

@LMESTM LMESTM force-pushed the Q12018_stm32_ustickers branch from d1945b2 to 79e6851 Compare March 30, 2018 16:07
@cmonr
Copy link
Contributor

cmonr commented Apr 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2018

Build : SUCCESS

Build number : 1634
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6463/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2018

Test : SUCCESS

Build number : 1421
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6463/1421

@mbed-ci
Copy link

mbed-ci commented Apr 2, 2018

Exporter Build : FAILURE

Build number : 1264
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6463/

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

Exporter Build : SUCCESS

Build number : 1269
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6463/

@0xc0170 0xc0170 merged commit 3821b54 into ARMmbed:feature-hal-spec-ticker Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@c1728p9 c1728p9 Awaiting requested review from c1728p9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LMESTM @cmonr @0xc0170 @mbed-ci @jeromecoutant @bulislaw