Provide fixes for HAL ticker test #6472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevew817 Please review |
|
Tested with EFM32PG12_STK3402 👍 After merging #6471 |
geky
approved these changes
Mar 27, 2018
|
I added also fix for DEVICE_LOWPOWERTIMER symbol which has been changed to DEVICE_LPTICKER. |
|
Echoing @geky 's findings, LGTM |
0xc0170
approved these changes
Mar 27, 2018
bulislaw
approved these changes
Mar 27, 2018
bulislaw
force-pushed
the
feature-hal-spec-ticker
branch
from
afd66ab to
6daa7fc
Compare
|
@mprse done |
bulislaw
force-pushed
the
feature-hal-spec-ticker_tests_fixes
branch
from
bb71c25 to
4cbace4
Compare
|
@0xc0170 done |
Increment test proves that ticker counter is incremented by one. This is done indirectly for high frequency counters where it is impossible to read 'value' and 'value + 1' in two successive ticker reads. This check is done indirectly by counting ticker ticks elapsed during execution of N cycles of empty while loop. Unfortunately on slow boards with fast tickers like NRF51_DK(16 MHz CPU/1MHz hf ticker) it is possible that for the same N cycles measured number of elapsed ticks in two successive calls is greater than 1. This patch provides fix for such case - measure operation is repeated with the same number of cycles.
On slow targets with fast high frequency tickers like NRF51_DK (16 Mhz CPU/1MHz ticker) time window for test case execution without overflow needs to be increased. Add parameter to `overflow_protect` function to be able to set different time window without overflow for us ticker and lp ticker.
…instead test setup handler. This is done to bypass green-tea setup handler which takes additional time.
- count_ticks: fix counter overflow handling, - count_ticks: use reg_cycles variable in while loop, - increment test: reduce number of cycles for slow cores if measure process needs to be repeated (difference is greater than 1).
mprse
force-pushed
the
feature-hal-spec-ticker_tests_fixes
branch
from
4cbace4 to
42ffc3f
Compare
|
Rebased this PR and removed |
|
Will soon CI soon |
|
/morph build |
Build : SUCCESSBuild number : 1592 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1229 |
Test : SUCCESSBuild number : 1380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide fixes for HAL lp/us ticker test.
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change