Skip to content

Adding missing @deprecated to function inline documentation #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2018

Conversation

yossi2le
Copy link
Contributor

Description

In this refactoring we fix only the inline documentation of function which already has the MBED_DEPRECATED macro but the @deprecated is not updated.

Pull request type

[x] Refactor

cmonr
cmonr previously approved these changes Mar 29, 2018
@cmonr cmonr requested a review from geky March 29, 2018 15:35
@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2018

@geky FYI

@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2018

@yossi2le Please take a look and address the Travis CI docs issues.

@studavekar
Copy link
Contributor

/morph build

as per @cmonr request aborted the build.

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2018

Build : SUCCESS

Build number : 1628
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6510/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2018

@studavekar
Copy link
Contributor

Test : FAILURE
Build number : 1413
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6510/1413

re-triggering for UBLOX failure

/morph test

@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2018

@studavekar Did the build actually stop?

@mbed-ci
Copy link

mbed-ci commented Mar 29, 2018

geky
geky previously approved these changes Mar 30, 2018
Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@yossi2le yossi2le dismissed stale reviews from geky and cmonr via 8684a63 April 2, 2018 10:25
@yossi2le
Copy link
Contributor Author

yossi2le commented Apr 2, 2018

@cmonr I have fixed the Travis CI issue.
Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1649
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6510/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

@OPpuolitaival CAn you please restart jenkins CI? Seems like it is picking the sha commit that is not there ? Restart did not help

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

I'll close and reopen this PR , that might help to resolve jenkins CI git issue we are seeing.

@0xc0170 0xc0170 closed this Apr 4, 2018
@0xc0170 0xc0170 reopened this Apr 4, 2018
@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Build : SUCCESS

Build number : 1656
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6510/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

We are investigating jenkins CI failure, it is not related to this PR. There are few other PR affected.

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

Restarting,

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

@cmonr cmonr merged commit 7dabd24 into ARMmbed:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants