Skip to content

Move Mbed 5 support check so that it affects the exporters #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

A recent PR of mine stopped the exporters from using the build_api's
unified scan_resourcses method. Instead, I moved the supported check to
the earliest location that we have this informaiton: the end of the
config object's load_resources method.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

I suppose this code reactor allows the export command to fail much sooner in the export process?

@cmonr cmonr added the needs: CI label Apr 3, 2018
@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1637
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6512/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

@cmonr Can you review the latest test result? It's related to the patch you sent earlier, and it's on master branch?

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@theotherjimmy
Copy link
Contributor Author

@cmonr Yes, it failes before it get to the exporter. It may have even got to the compiler in the IDE before 😱

@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

@0xc0170 Am doing
@theotherjimmy xD

@cmonr cmonr merged commit 4a5ac14 into ARMmbed:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants