Skip to content

Inrease thread stack size to 1024 bytes in NVStore test for NRF52 #6518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Inrease thread stack size to 1024 bytes in NVStore test for NRF52 #6518

merged 1 commit into from
Apr 4, 2018

Conversation

marcuschangarm
Copy link
Contributor

Description

On the NRF52, the NVStore test is running at the stack boundary so on certain compiler versions the test will fail due to stack overflow. This PR increases the stack size for the NRF52 target.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@marcuschangarm
Copy link
Contributor Author

@davidsaada @geky

@davidsaada
Copy link
Contributor

@marcuschangarm I was really trying to avoid these target specific ifdefs in my code, working pretty hard in the NVStore tests to achieve it (I do remember the NRF52 board giving me hard time doing so).
Perhaps the best way to achieve this goal would be to inquire how much free heap size we have, and tune the test code accordingly. However, I don't know if such an API (for inquiring free heap size) even exists, do you?

@marcuschangarm
Copy link
Contributor Author

There might be with the mem stats functions but I'm not sure.

Do you mind solving this in a later PR? This is really blocking my work and our deliverable to several companies.

@davidsaada
Copy link
Contributor

Do you mind solving this in a later PR? This is really blocking my work and our deliverable to several companies.

No problem. Will probably handle it after I'm back from my vacation in a week or so.
Would just like the understand the reason for this failure., as this test previously passed successfully. I see you added many changes, and wonder if they were all related to this board only. If they are not, I suspect the test may fail for other boards as well.

@marcuschangarm
Copy link
Contributor Author

Thank you! Hope you have a great vacation!

The whole SDK has been upgraded for the NRF52 so I'm not surprised that the behavior has changed a lot!

@cmonr cmonr requested review from geky and davidsaada April 3, 2018 02:04
@cmonr
Copy link
Contributor

cmonr commented Apr 3, 2018

@marcuschangarm Is there a reason that this PR is targeting master instead of your feature branch?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

@marcuschangarm Is there a reason that this PR is targeting master instead of your feature branch?

Shall this be targeting your feature nrf branch rather? That would unblock feature progress, and meantime @davidsaada will look review this and propose a correct fix?

@marcuschangarm
Copy link
Contributor Author

I'm targeting master so that I can use the CI to test the rebase branches.

Also, I'm not comfortable changing a test inside the same PR the test would have failed for.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

Build : SUCCESS

Build number : 1645
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6518/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the future investigation (fix) for the proper thread stack value in this test

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 3, 2018

@0xc0170 0xc0170 merged commit 1529ad6 into ARMmbed:master Apr 4, 2018
@marcuschangarm marcuschangarm deleted the fix-nvstore-stack branch April 5, 2018 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants