-
Notifications
You must be signed in to change notification settings - Fork 3k
Inrease thread stack size to 1024 bytes in NVStore test for NRF52 #6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@marcuschangarm I was really trying to avoid these target specific ifdefs in my code, working pretty hard in the NVStore tests to achieve it (I do remember the NRF52 board giving me hard time doing so). |
There might be with the mem stats functions but I'm not sure. Do you mind solving this in a later PR? This is really blocking my work and our deliverable to several companies. |
No problem. Will probably handle it after I'm back from my vacation in a week or so. |
Thank you! Hope you have a great vacation! The whole SDK has been upgraded for the NRF52 so I'm not surprised that the behavior has changed a lot! |
@marcuschangarm Is there a reason that this PR is targeting master instead of your feature branch? |
Shall this be targeting your feature nrf branch rather? That would unblock feature progress, and meantime @davidsaada will look review this and propose a correct fix? |
I'm targeting master so that I can use the CI to test the rebase branches. Also, I'm not comfortable changing a test inside the same PR the test would have failed for. |
/morph build |
Build : SUCCESSBuild number : 1645 Triggering tests/morph test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with the future investigation (fix) for the proper thread stack value in this test
Exporter Build : SUCCESSBuild number : 1277 |
Test : SUCCESSBuild number : 1434 |
Description
On the NRF52, the NVStore test is running at the stack boundary so on certain compiler versions the test will fail due to stack overflow. This PR increases the stack size for the NRF52 target.
Pull request type
[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change