Skip to content

Updated macro that disables flash cache test #6535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Updated macro that disables flash cache test #6535

wants to merge 1 commit into from

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Apr 3, 2018 •
edited
Loading

Description

A continuation of #6340. That PR did not actually disable the test. A different macro has been used and verified to work.

Greentea logs showing that the sub-test in question is appropriately disabled.
nrf52.txt
lpc1768.txt

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr cmonr requested review from 0xc0170, adbridge and studavekar April 3, 2018 21:45
studavekar
studavekar previously approved these changes Apr 4, 2018
View reviewed changes
@studavekar
Copy link
Contributor

studavekar commented Apr 4, 2018 •
edited
Loading

Thanks @cmonr for locally testing the change.
LGTM 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 4, 2018

/morph build

0xc0170
0xc0170 requested changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it was changed from NRF52 to all nordic devices?

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Build : SUCCESS

Build number : 1654
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6535/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Exporter Build : SUCCESS

Build number : 1286
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6535/

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Test : SUCCESS

Build number : 1446
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6535/1446

@cmonr cmonr force-pushed the disable-failing-flash-test branch from a100660 to ce1de96 Compare April 4, 2018 15:38
@cmonr
Copy link
Contributor Author

cmonr commented Apr 4, 2018

@0xc0170 Good point. Switched over to what @studavekar originally suggested in other PR.

If you could re-review, since PR has been updated and squashed.

@cmonr
Copy link
Contributor Author

cmonr commented Apr 4, 2018

Updated logs.

lpc1768.txt
nrf52.txt

@cmonr cmonr changed the title Updated macro that is used to actually disable flash cache test Updated macro that disables flash cache test Apr 4, 2018
@cmonr
Copy link
Contributor Author

cmonr commented Apr 4, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Build : SUCCESS

Build number : 1662
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6535/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 4, 2018

Exporter Build : SUCCESS

Build number : 1295
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6535/

@mbed-ci
Copy link

mbed-ci commented Apr 5, 2018

Test : SUCCESS

Build number : 1457
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6535/1457

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 5, 2018

Waiting for jenkins CI - fails because of github references (the old commit for this PR refs 😕 )

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2018

Github engineers are looking at the ref failures to get latest commit, will report back once we receive more info

@cmonr cmonr mentioned this pull request Apr 11, 2018
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 17, 2018 •
edited
Loading

Restarting the CI (2 weeks ago the latest run)

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

Build : SUCCESS

Build number : 1772
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6535/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

Exporter Build : SUCCESS

Build number : 1413
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6535/

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Test : SUCCESS

Build number : 1582
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6535/1582

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

With the update for NRF52 that is already in the queue , this should be revised asap. We haven't seen the issue in the last days, is this still relevant?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

Can we fix it ? And remove the ifdef from there completely?

0xc0170
0xc0170 requested changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to fix it

@0xc0170 0xc0170 closed this Apr 20, 2018
@cmonr cmonr mentioned this pull request Apr 27, 2018
Closed
@kjbracey kjbracey mentioned this pull request Apr 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 requested changes

@studavekar studavekar studavekar left review comments

@adbridge adbridge Awaiting requested review from adbridge

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cmonr @studavekar @0xc0170 @mbed-ci