Travis: Fix rate-limit issue with Github requests #6564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using credentials avoids rate-limiting based on Travis's IP address
0xc0170
approved these changes
Apr 9, 2018
|
/morph build |
Build : SUCCESSBuild number : 1695 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1328 |
Test : SUCCESSBuild number : 1489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using credentials avoids rate-limiting based on Travis's IP address
Description
Sometimes curl commands against the Github API fail. Turns out this is caused by rate-limiting when credentials aren't provided, which is then based on Travis's IP address. Always using credentials even for GETs to public endpoints fixes the problem.
Note, this isn't high priority since right now we're only using uncredentialed GETs in status messages.
Pull request type
[✓] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change