Skip to content

Lora: small fixes #6569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 12, 2018
Merged

Lora: small fixes #6569

merged 3 commits into from
Apr 12, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Apr 9, 2018

Description

Small fixes to LoRa stack

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 9, 2018

@kjbracey-arm, @AnttiKauppila, @hasnainvirk, please review this.

Kimmo Vaisanen added 3 commits April 10, 2018 10:13
_mcps_indication.status is not initialized properly and it can cause incorrect
status value to be returned.
Fixed Coverity warning "stored value is overwritten before it can be used".
@hasnainvirk
Copy link
Contributor

@kivaisan This will need a rebase and testing again as Antti's stuff is in.

@kivaisan
Copy link
Contributor Author

kivaisan commented Apr 10, 2018

Rebased to latest mbed-os. @0xc0170 could you please start required builds / tests.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2018

To understand this PR - there are 3 commits that look like fixes and the last one as adding new functionality that can be separate PR (feature) ?
/morph build

@kivaisan kivaisan changed the title Lora: new receive() method and small fixes Lora: small fixes Apr 10, 2018
@kivaisan
Copy link
Contributor Author

@0xc0170 this PR is now just those small fixes. I'll create a new PR (feature) about the new receive API.

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1700
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@cmonr
Copy link
Contributor

cmonr commented Apr 10, 2018

Restarting build since commits were updated after last build was started.

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

Build : SUCCESS

Build number : 1709
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6569/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 11, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

Sync failues for one device, I noticed this this morning, I restarted another job, will wait for results and this might need reconnect

@studavekar

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2018

@cmonr cmonr merged commit 68ebbb0 into ARMmbed:master Apr 12, 2018
@adbridge
Copy link
Contributor

This edits code introduced by #6411 which is targeting 5.9, thus this cannot go to a patch release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants