-
Notifications
You must be signed in to change notification settings - Fork 3k
Lora: small fixes #6569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lora: small fixes #6569
Conversation
@kjbracey-arm, @AnttiKauppila, @hasnainvirk, please review this. |
_mcps_indication.status is not initialized properly and it can cause incorrect status value to be returned.
Fixed Coverity warning "stored value is overwritten before it can be used".
@kivaisan This will need a rebase and testing again as Antti's stuff is in. |
Rebased to latest mbed-os. @0xc0170 could you please start required builds / tests. |
To understand this PR - there are 3 commits that look like fixes and the last one as adding new functionality that can be separate PR (feature) ? |
@0xc0170 this PR is now just those small fixes. I'll create a new PR (feature) about the new receive API. |
Build : SUCCESSBuild number : 1700 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1334 |
Restarting build since commits were updated after last build was started. /morph build |
Build : SUCCESSBuild number : 1709 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1343 |
Test : FAILUREBuild number : 1504 |
Sync failues for one device, I noticed this this morning, I restarted another job, will wait for results and this might need reconnect |
/morph test |
Test : SUCCESSBuild number : 1518 |
This edits code introduced by #6411 which is targeting 5.9, thus this cannot go to a patch release. |
Description
Small fixes to LoRa stack
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change