Cellular: add detach from the network #6570
Conversation
| @@ -665,7 +665,7 @@ bool AT_CellularNetwork::has_registration(RegistrationType reg_type) | |||
| return true; | |||
| } | |||
|
|
|||
| nsapi_error_t AT_CellularNetwork::set_attach(int timeout) | |||
| nsapi_error_t AT_CellularNetwork::set_attach(int /*timeout*/) | |||
There was a problem hiding this comment.
I guess that "timeout" is and will not be used, so could add deprecated notice?
There was a problem hiding this comment.
good point, added deprecation
|
/morph build |
Build : SUCCESSBuild number : 1698 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1332 |
Test : FAILUREBuild number : 1494 |
|
Interesting. Sync failed with the MAX32630. /morph test |
Test : SUCCESSBuild number : 1511 |
jarvte
force-pushed
the
add_cellular_detach
branch
from
5b0e955 to
0b5fae3
Compare
|
Recently rebased? Restarting CI /morph build |
|
Yes, conflicts did appear so I had to rebase and fix. |
Build : SUCCESSBuild number : 1728 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1363 |
Test : SUCCESSBuild number : 1533 |
|
/morph export-build |
Exporter Build : SUCCESSBuild number : 1365 |
|
@0xc0170 github issue again? Should I rebase master? |
Restarted it, should be fixed, waiting for it to complete |
0xc0170
changed the title
Description
Added detach from cellular network.
@AriParkkila please review.
Internal ref to defect: IOTCELL-758
Pull request type
[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change