-
Notifications
You must be signed in to change notification settings - Fork 3k
Lora: Introduce new receive API which returns port and flags #6586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a fix for issue #6389. Currently when application receives RX_DONE event from stack, it has to provide the correct port value to receive method in order to read the received message. The problem is that current API does not provide any way to know in to which port message was received. This commit introduces a new receive() method, which instead of checking these values, will return them to application.
@AnttiKauppila @hasnainvirk @kjbracey-arm please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any tests for this new method?
@0xc0170 Tests are currently internal. |
/morph build |
Build : SUCCESSBuild number : 1706 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 1340 |
Legitimately confused. Maybe the build machine ran out of space? /morph export-build
|
Exporter Build : SUCCESSBuild number : 1348 |
Test : FAILUREBuild number : 1500 |
/morph test |
Test : SUCCESSBuild number : 1522 |
Description
This is a fix for issue #6389.
Currently when application receives RX_DONE event from stack, it has to provide the correct port
value to receive method in order to read the received message. The problem is that current
API does not provide any way to know in to which port message was received.
This commit introduces a new receive() method, which instead of checking these values, will return
them to application.
This is mbed-os 5.9 content.
Pull request type
[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change