-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix typo with NVStore #6595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo with NVStore #6595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was actually removed in this PR, waiting to be merged. Reason is, as you also noticed, that this structure is initialized at init phase. I don't mind approving this PR, until my PR is merged, if it helps fixing an immediate issue.
@davidsaada Should this be integrated first as bugfix, thus would be part of the next patch release. And your PR would be for the next minor as adding new API? |
Yes, I believe it's the right thing to do. |
/morph build |
Build : SUCCESSBuild number : 1720 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1356 |
Test : SUCCESSBuild number : 1520 |
This line did not even come into the code base until #6388 which is marked for 5.9 so not sure this should be patched ! |
Description
I believe the below code is a typo:
mbed-os/features/nvstore/source/nvstore.cpp:
And I fix as below:
Because
_flash_area_params
will be re-initialized later, the typo won't cause trouble on most targets. But it will on NUMAKER_PFM_M2351 port of which is on-going. NUMAKER_PFM_M2351 is Cortex-M23 based and has TrustZone support. Read flash address0
is not always legal because flash is partitioned into secure/non-secure.[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change