Skip to content

[IOTCELL] Setting up channels for AU915 #6600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2018
Merged

[IOTCELL] Setting up channels for AU915 #6600

merged 1 commit into from
Apr 13, 2018

Conversation

hasnainvirk
Copy link
Contributor

Description

Bug was reported by @tpet93 and it was correctly diagnosed that channels
were not being set in the phy_params structure. This commit fixes the bug
and sets up channels correctly.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@hasnainvirk hasnainvirk mentioned this pull request Apr 11, 2018
Closed
@hasnainvirk
Copy link
Contributor Author

@kivaisan @AnttiKauppila Please review.

[IOTCELL] Setting up channels for AU915
ec34796 
Bug was reported by @tpet93 and it was correctly diagnosed that channels
were not being set in the phy_params structure. This commit fixes the bug
and sets up channels correctly.
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 11, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 11, 2018

Build : SUCCESS

Build number : 1722
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6600/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 11, 2018

Exporter Build : SUCCESS

Build number : 1358
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6600/

@hasnainvirk
Copy link
Contributor Author

@kjbracey-arm Please review this.

kjbracey
kjbracey approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@kjbracey kjbracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the passing observation that I see all those void * casts are papering over a const-correctness problem. Should be fixed at some point in a future refactor if possible.

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2018

Test : SUCCESS

Build number : 1527
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6600/1527

@hasnainvirk
Copy link
Contributor Author

hasnainvirk commented Apr 13, 2018 •
edited
Loading

@0xc0170 @cmonr This can be merged.

@cmonr cmonr merged commit 4343253 into ARMmbed:master Apr 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjbracey kjbracey kjbracey approved these changes

@AnttiKauppila AnttiKauppila AnttiKauppila approved these changes

@kivaisan kivaisan kivaisan approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hasnainvirk @0xc0170 @mbed-ci @kjbracey @AnttiKauppila @kivaisan @cmonr