rtl8195am - Fix more compiler warnings #6651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warnings: [Warning] i2c_api.c@94,26: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] i2c_api.c@231,5: implicit declaration of function 'memset' [-Wimplicit-function-declaration] [Warning] i2c_api.c@460,14: unused variable 'i2c_default_addr' [-Wunused-variable] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings: [Warning] log_uart_api.c@58,38: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] log_uart_api.c@151,38: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] log_uart_api.c@260,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@268,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@276,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@290,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@328,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@338,27: unused variable 'pUartAdapter' [-Wunused-variable] [Warning] log_uart_api.c@376,45: pointer targets in passing argument 2 of 'HalLogUartRecv' differ in signedness [-Wpointer-sign] [Warning] log_uart_api.c@386,45: pointer targets in passing argument 2 of 'HalLogUartSend' differ in signedness [-Wpointer-sign] Signed-off-by: Tony Wu <[email protected]>
Fix the following warning: [Warning] pwmout_api.c@65,29: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings: [Warning] hal_ssi.h@28,85: suggest braces around empty body in an 'if' statement [-Wempty-body] [Warning] spi_api.c@87,27: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] spi_api.c@76,14: unused variable 'MaxSsiFreq' [-Wunused-variable] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings: [Warning] osdep_service.c@58,11: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] osdep_service.c@208,61: suggest braces around empty body in an 'else' statement [-Wempty-body] [Warning] osdep_service.c@1063,16: pointer targets in passing argument 1 of '_rtw_mfree' differ in signedness [-Wpointer-sign] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings:
[Warning] wifi_conf.c@326,28: suggest parentheses around comparison in operand of '|' [-Wparentheses]
[Warning] wifi_conf.c@451,39: format '%x' expects argument of type 'unsigned int *', but argument 3 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@451,43: format '%x' expects argument of type 'unsigned int *', but argument 4 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@451,47: format '%x' expects argument of type 'unsigned int *', but argument 5 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@451,51: format '%x' expects argument of type 'unsigned int *', but argument 6 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@451,55: format '%x' expects argument of type 'unsigned int *', but argument 7 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,39: format '%x' expects argument of type 'unsigned int *', but argument 3 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,43: format '%x' expects argument of type 'unsigned int *', but argument 4 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,47: format '%x' expects argument of type 'unsigned int *', but argument 5 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,51: format '%x' expects argument of type 'unsigned int *', but argument 6 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,55: format '%x' expects argument of type 'unsigned int *', but argument 7 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,59: format '%x' expects argument of type 'unsigned int *', but argument 8 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,63: format '%x' expects argument of type 'unsigned int *', but argument 9 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 10 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 11 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 12 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 13 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 14 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@460,35: format '%x' expects argument of type 'unsigned int *', but argument 15 has type 'u32 * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@831,16: format '%d' expects argument of type 'int *', but argument 3 has type 'rtw_security_t * {aka long unsigned int *}' [-Wformat=]
[Warning] wifi_conf.c@1335,2: suggest parentheses around assignment used as truth value [-Wparentheses]
[Warning] wifi_conf.c@1398,13: pointer targets in passing argument 1 of 'rtw_mfree' differ in signedness [-Wpointer-sign]
[Warning] wifi_conf.c@1724,7: variable 'ret' set but not used [-Wunused-but-set-variable]
[Warning] wifi_conf.c@1770,6: variable 'ret' set but not used [-Wunused-but-set-variable]
Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings:
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 3 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 4 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 5 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 6 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 7 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@62,104: format '%x' expects argument of type 'unsigned int*', but argument 8 has type 'uint8_t* {aka unsigned char*}' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 3 has type 'char*' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 4 has type 'char*' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 5 has type 'char*' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 6 has type 'char*' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 7 has type 'char*' [-Wformat=]
[Warning] rtw_emac.cpp@201,101: format '%x' expects argument of type 'unsigned int*', but argument 8 has type 'char*' [-Wformat=]
Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings:
[Warning] tcm_heap.c@70,18: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=]
[Warning] tcm_heap.c@70,28: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'MemChunk * {aka struct _MemChunk *}' [-Wformat=]
[Warning] tcm_heap.c@336,6: unused variable 'i' [-Wunused-variable]
Signed-off-by: Tony Wu <[email protected]>
Fix the following warning: [Warning] lwip_intf.c@134,5: this 'if' clause does not guard... [-Wmisleading-indentation] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings: [Warning] wifi_promisc.c@113,61: missing braces around initializer [-Wmissing-braces] [Warning] wifi_promisc.c@297,52: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] wifi_promisc.c@403,52: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Tony Wu <[email protected]>
Fix the following errors: [Warning] dhcps.c@158,1: label 'Exit' defined but not used [-Wunused-label] [Warning] dhcps.c@161,13: 'dump_client_table' defined but not used [-Wunused-function] Signed-off-by: Tony Wu <[email protected]>
Fix the following warnings: [Warning] wifi_util.c@791,20: comparison between signed and unsigned integer expressions [-Wsign-compare] [Warning] wifi_util.c@835,21: comparison between signed and unsigned integer expressions [-Wsign-compare] Signed-off-by: Tony Wu <[email protected]>
0xc0170
approved these changes
Apr 17, 2018
|
How many warnings previously and now? /morph build |
|
Reduced to 37 from 108. |
Build : SUCCESSBuild number : 1773 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1414 |
Test : SUCCESSBuild number : 1583 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix trivial compiler warnings, no logic changed.
Pull request type
[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change