Skip to content

Allow library configs to override target configs #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 19, 2018
Merged

Allow library configs to override target configs #6658

merged 3 commits into from
Apr 19, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

The documentation currently claims that libraries are allowed to
override target configuration. This fixes a bug that would prevent a
library configuration from overriding a target configuration.
Application configuration is unaffected.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@marcuschangarm marcuschangarm mentioned this pull request Apr 17, 2018
Merged
@0xc0170 0xc0170 requested a review from screamerbg April 18, 2018 11:15
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 18, 2018

Please review travis failures and jenkins CI

screamerbg
screamerbg previously approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@screamerbg screamerbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cc @sg-

@screamerbg
Copy link
Contributor

These definitely need fixing.

@0xc0170 0xc0170 requested a review from sg- April 18, 2018 11:31
@theotherjimmy
Copy link
Contributor Author

@screamerbg

These definitely need fixing.

Agreed. I'm working on it.

@cmonr
Copy link
Contributor

cmonr commented Apr 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 18, 2018

Build : SUCCESS

Build number : 1791
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6658/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 19, 2018

Exporter Build : ABORTED

Build number : 1439
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6658/

@mbed-ci
Copy link

mbed-ci commented Apr 19, 2018

Test : SUCCESS

Build number : 1601
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6658/1601

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2018

/morph export-build

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2018 •
edited
Loading

Agreed. I'm working on it.

@theotherjimmy Is this complete?

@mbed-ci
Copy link

mbed-ci commented Apr 19, 2018

Exporter Build : SUCCESS

Build number : 1440
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6658/

@theotherjimmy
Copy link
Contributor Author

@0xc0170 Yes.

0xc0170
0xc0170 approved these changes Apr 19, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@screamerbg Approval, LGTM as well

@0xc0170 0xc0170 merged commit 42d77ec into ARMmbed:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@screamerbg screamerbg screamerbg left review comments

@sg- sg- Awaiting requested review from sg-

Assignees
No one assigned
Labels
release-version: 5.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theotherjimmy @0xc0170 @screamerbg @cmonr @mbed-ci