Skip to content

Cellular: fixed null pointer bug in cellular fsm #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Apr 19, 2018

Description

Cellular: fixed possible crash bug in cellular state machine.
After stop() call there might have been a call to null pointer.

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from AriParkkila April 19, 2018 10:27
@0xc0170 0xc0170 changed the title Cellular: fixed possible crash bug in cellular state machine. Cellular: fix possible crash bug in cellular state machine. Apr 19, 2018
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does it crash and how is it fixing? (add some detailed info to the commit message if possible)

@jarvte jarvte changed the title Cellular: fix possible crash bug in cellular state machine. Cellular: fix possible crash bug in cellular state machine. After stop() call there might have been a call to null pointer. Apr 19, 2018
@jarvte
Copy link
Contributor Author

jarvte commented Apr 19, 2018

@0xc0170 updated commit and pr message

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 19, 2018

@0xc0170 updated commit and pr message

I see the title changed (the title should be 50 characters the most, same as first line in the commit message. The title here is used also in the release notes). The commit message (1st paragraph should contain the details about it). but commit has not changed, a push missing?

Null pointer could have been called after stop() in cellular state machine.
@jarvte jarvte force-pushed the cellular_fsm_crash_bug branch from c345d08 to 6a2eefb Compare April 19, 2018 11:35
@jarvte jarvte changed the title Cellular: fix possible crash bug in cellular state machine. After stop() call there might have been a call to null pointer. Cellular: fixed null pointer bug in cellular fsm Apr 19, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2018

Build : SUCCESS

Build number : 1816
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6677/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2018

@jarvte
Copy link
Contributor Author

jarvte commented Apr 25, 2018

@0xc0170 merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants