Skip to content

Update URL that points at a blank page. #6688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sg-
Copy link
Contributor

@sg- sg- commented Apr 19, 2018

Description

Looks like the URL changed where #workflow became workflow.html. Also update the issue type to be a checkbox

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

sg- added 2 commits April 19, 2018 17:12
Looks like the URL changed where #workflow became workflow.html
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2018

Looks like the URL changed where #workflow became workflow.html. Also update the issue type to be a checkbox

Good catch with URL, works now!

The checkbox is problematic as we found out thus was changed to the current form. Github treats its as TODO list which is not true for this use. As this can be viewed if this is referenced in another PR, its shows then 1 of 5 tasks complete 😞 See https://blog.github.com/2013-01-09-task-lists-in-gfm-issues-pulls-comments/

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

I'll close this one. Cherry picked the first commit here #6727.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants