Skip to content

STM32 RTC Init minor update #6723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2018
Merged

STM32 RTC Init minor update #6723

merged 1 commit into from
Apr 25, 2018

Conversation

jeromecoutant
Copy link
Collaborator

Description

There is no functional update.
This is mainly to prevent potential issues with CI and all test environnment when the ticker branch will be merged.

Thx

Pull request type

[ ] Fix
[X] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

0xc0170
0xc0170 reviewed Apr 24, 2018
View reviewed changes
targets/TARGET_STM/rtc_api.c Outdated
@@ -53,7 +53,7 @@ void rtc_init(void)
__HAL_RCC_PWR_CLK_ENABLE();
HAL_PWR_EnableBkUpAccess();

if (rtc_isenabled()) {
if ( (rtc_isenabled()) && ((RTC->PRER & RTC_PRER_PREDIV_S) == PREDIV_S_VALUE) ) {
Copy link
Contributor

@0xc0170 0xc0170 Apr 24, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not functional change? Why the new flags are being added? This looks like a separate change to the below code move?

Would a separate commit with description help? I think yes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this additional check doesn't change the behavior as it checks that the current register configuration is the one according to the code.
Which is true 99% of time, except when you will move from master to/from ticker branch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I see it now that PREDIV are being checked.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

/morph build

0xc0170
0xc0170 previously approved these changes Apr 24, 2018
View reviewed changes
@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Build : FAILURE

Build number : 1834
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6723/

@jeromecoutant
Copy link
Collaborator Author

Build issue solved
Sorry

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1836
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6723/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Exporter Build : SUCCESS

Build number : 1481
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6723/

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Test : SUCCESS

Build number : 1643
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6723/1643

@cmonr cmonr removed the needs: CI label Apr 25, 2018
@0xc0170 0xc0170 merged commit b5b35fb into ARMmbed:master Apr 25, 2018
@jeromecoutant jeromecoutant deleted the PR_RTC_INIT branch April 25, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeromecoutant @0xc0170 @mbed-ci @cmonr