Skip to content

Add bootloader support for NUCLEO_F411RE target #6729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2018
Merged

Add bootloader support for NUCLEO_F411RE target #6729

merged 1 commit into from
May 3, 2018
+29 −23

Conversation

JammuKekkonen
Copy link
Contributor

@JammuKekkonen JammuKekkonen commented Apr 24, 2018 •
edited by 0xc0170
Loading

Description

Add bootloader support for NUCLEO_F411RE board.

Tested with mbed-bootloader + blinky, with all three compilers.

Ref: #5228 - bootloader support for NUCLEO_F446RE

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

@JammuKekkonen
Copy link
Contributor Author

JammuKekkonen commented Apr 24, 2018 •
edited
Loading

@JanneKiiskila @yogpan01 @teetak01

@JanneKiiskila
Copy link
Contributor

@kjbracey-arm - can we get this reviewed?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 24, 2018

@ARMmbed/team-st-mcd Please review

jeromecoutant
jeromecoutant suggested changes Apr 24, 2018
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F411xE/device/TOOLCHAIN_ARM_STD/stm32f411re.sct Outdated
#endif

#if !defined(MBED_APP_SIZE)
#define MBED_APP_SIZE 0x100000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 0x80000 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - target has 512K (0x80000)

targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F411xE/device/TOOLCHAIN_IAR/stm32f411xe.icf Outdated
@@ -1,7 +1,10 @@
if (!isdefinedsymbol(MBED_APP_START)) { define symbol MBED_APP_START = 0x08000000; }
if (!isdefinedsymbol(MBED_APP_SIZE)) { define symbol MBED_APP_SIZE = 0x100000; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 0x80000 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JammuKekkonen
Copy link
Contributor Author

PR updated

jeromecoutant
jeromecoutant reviewed Apr 24, 2018
View reviewed changes
targets/TARGET_STM/TARGET_STM32F4/TARGET_STM32F411xE/device/TOOLCHAIN_IAR/stm32f411xe.icf Outdated
define symbol __region_ROM_end__ = 0x0807FFFF;
define symbol __intvec_start__ = MBED_APP_START;
define symbol __region_ROM_start__ = MBED_APP_START;
define symbol __region_ROM_end__ = MBED_APP_START + MBED_APP_SIZE;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

define symbol region_ROM_end = MBED_APP_START + MBED_APP_SIZE -1; ?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

@jeromecoutant Happy with the changes?

0xc0170
0xc0170 previously approved these changes Apr 26, 2018
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

@JammuKekkonen Please review jenkins failure, linking errors related to the changes here

@JammuKekkonen
Copy link
Contributor Author

New try. Added the missing armcc preprocessor directive.

@adbridge adbridge requested a review from kjbracey April 30, 2018 11:27
@0xc0170
Copy link
Contributor

0xc0170 commented May 2, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

Build : SUCCESS

Build number : 1890
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6729/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

Exporter Build : SUCCESS

Build number : 1538
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6729/

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Test : SUCCESS

Build number : 1707
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6729/1707

@0xc0170 0xc0170 merged commit 45b3fff into ARMmbed:master May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMESTM LMESTM LMESTM left review comments

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.8.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JammuKekkonen @JanneKiiskila @0xc0170 @mbed-ci @jeromecoutant @LMESTM