Skip to content

LPC54XXX: Set the pin function to Digital mode #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

We cannot rely on the default value as a pin could be use for Analog purposes in which this bit is cleared. This was discovered when running AnalogIn ci-shield tests that uses the pin for Analog Input and then switches the pin to GPIO output.

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

We cannot rely on the default value as a pin could
be use for Analog purposes in which this bit is cleared

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170

@mmahadevan108 mmahadevan108 changed the title LPC546XX: Set the pin function to Digital mode LPC54XXX: Set the pin function to Digital mode Apr 24, 2018
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@cmonr
Copy link
Contributor

cmonr commented Apr 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

Build : SUCCESS

Build number : 1841
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6734/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 24, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

@cmonr cmonr merged commit 4e1c04f into ARMmbed:master Apr 27, 2018
@mmahadevan108 mmahadevan108 deleted the Fix_LPC54XXX_GPIO branch May 1, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants