Skip to content

Clarify mesh configuration values. #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Conversation

SeppoTakalo
Copy link
Contributor

@SeppoTakalo SeppoTakalo commented Apr 25, 2018

Description

A number of the configuration values in the mbed_lib.json files for Mesh contain 'help' fields which were missing acceptable ranges for their associated values.
This PR adds the missing ranges.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Most of the help fields were correct. Just add field specifying
acceptable ranges.
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 25, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

Build : SUCCESS

Build number : 1854
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6745/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 25, 2018

@cmonr
Copy link
Contributor

cmonr commented Apr 26, 2018

@SeppoTakalo With future PRs, please be sure to indicate the type of PR is being submitted. This PR has been modified as an example.

@cmonr cmonr merged commit a19a528 into ARMmbed:master Apr 27, 2018
@SeppoTakalo SeppoTakalo deleted the mesh_docs branch April 27, 2018 07:19
@SeppoTakalo
Copy link
Contributor Author

@cmonr Thanks for notifying. I removed the template completely because there were nothing related to documentation. But as this is correction of the documentation the [ x ] Fix is the correct category.

@adbridge
Copy link
Contributor

adbridge commented Apr 27, 2018

@SeppoTakalo The template should be left as is and a Description added where stated along with the PR type, otherwise the automated scripts that will soon run against all PRs will fail...In fact it explicitly gives this advice in the PR template itself.....
I've also updated the description itself to make it clear the level of detail we will be expecting here going forward.

@mbed-ci
Copy link

mbed-ci commented Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants