Skip to content

Support RTOS-less secure image build with Cortex-M23/M33 #6747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 26, 2018

Description

By following the instructions of Reducing memory usage by tuning RTOS configuration, I build RTOS-less secure image for on-going, Cortex-M23 based target NUMAKER_PFM_M2351, and meet compile error with mbed-os/rtos/TARGET_CORTEX/mbed_rtx_conf.h unavailable in RTOS-less build. My .mbedignore has the following content:

mbed-os/rtos/*
mbed-os/features/cellular/
mbed-os/features/FEATURE_CLIENT/*
mbed-os/features/FEATURE_COMMON_PAL/*
mbed-os/features/FEATURE_UVISOR/*
mbed-os/features/frameworks/*
mbed-os/features/net/*
mbed-os/features/netsocket/*
mbed-os/features/nvstore/*
mbed-os/features/storage/*
mbed-os/events/*
mbed-os/features/lorawan/*

This PR tries to fix the error. The support for RTOS-less secure image build would be helpful to reduce memory footprint.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani

@deepikabhavnani
Copy link

@ccli8 - We try to minimize changes in CMSIS files. It would be good to move defines into "cmsis/RTE_Components.h" (as that is Mbed OS specific) from mbed_rtx_conf.h.

CC @bulislaw

@ccli8
Copy link
Contributor Author

ccli8 commented Apr 26, 2018

@deepikabhavnani Please check the commit
02730f0 for the modification.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2018

Build : SUCCESS

Build number : 1858
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6747/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 26, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 27, 2018

@deepikabhavnani Can you review the update if now the location for those definitions is good?

Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants