LoRaWAN: Memory corruption due to band mishandling #6750
Merged
+40
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
band_t structure in phy parameters was not being filled in properly and we were spilling over the array boundary for bands. In addition to that two utility functions are added to perform safety checking taking in the frequency and filling out band information plus boundry value checks.
hasnainvirk
force-pushed
the
mem_corruption_fix
branch
from
5c2d030 to
a6a1cee
Compare
hasnainvirk
changed the title
|
@kivaisan @kjbracey-arm Can you please review ? |
kivaisan
approved these changes
Apr 26, 2018
0xc0170
approved these changes
Apr 26, 2018
|
/morph build |
Build : SUCCESSBuild number : 1861 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1509 |
Test : SUCCESSBuild number : 1672 |
|
Waiting for one final approval from requested reviewers |
kjbracey
approved these changes
Apr 27, 2018
AnttiKauppila
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
band_t structure in phy parameters was not being filled in properly
and we were spilling over the array boundary for bands.
In addition to that two utility functions are added to perform safety
checking taking in the frequency and filling out band information plus
boundary value checks.
Pull request type