Skip to content

Move subtract basepath into the resources class #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2018
Merged

Move subtract basepath into the resources class #6769

merged 1 commit into from
May 7, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

A bug, #6755, was the result of the subtract_basepath function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the subtract_basepath method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy
Copy link
Contributor Author

It's even shorter now 😄

@theotherjimmy
Copy link
Contributor Author

@cmonr Could you review?

@yennster @chris-styles This is the fix to both of your bugs.

@adbridge adbridge requested a review from cmonr April 30, 2018 11:18
@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

The changes looks good to me but

A bug, #6755, was the result of the subtract_basepath function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the subtract_basepath method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.

can you amend this to the commit message?

@theotherjimmy
Copy link
Contributor Author

@0xc0170 That'll be just a moment. I'll start testing after I do to keep things rolling.

@theotherjimmy
Apply subtract basepath to features
d338e67 
A bug, ARMmbed#6755, was the result of the `subtract_basepath` function not
being applied to a resources object's children (it's features). This PR
fixes this bug by moving this functionality into the resources class.
Then, I applied the `subtract_basepath` method to the children resource
objects recursively. This has been tested on Partnerbeta and is to
upstream the fix.
@theotherjimmy theotherjimmy force-pushed the fix-subtract-basepath branch from a7e7f8e to d338e67 Compare May 3, 2018 13:55
@theotherjimmy
Copy link
Contributor Author

@0xc0170 Added entire description field to the commit message.

/morph build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1907
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6769/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Exporter Build : SUCCESS

Build number : 1554
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6769/

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

Test : SUCCESS

Build number : 1725
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6769/1725

@cmonr cmonr merged commit 2ddce27 into ARMmbed:master May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theotherjimmy @0xc0170 @mbed-ci @cmonr