Skip to content

Fix UART initialization for NRF52 #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2018
Merged

Fix UART initialization for NRF52 #6771

merged 1 commit into from
May 7, 2018

Conversation

marcuschangarm
Copy link
Contributor

Description

Delayed initialization can cause problems when both UARTE instances
are in use. This change causes each UART object to initialize the
underlying UARTE instance immediately.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@kegilbert
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

Build : SUCCESS

Build number : 1882
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6771/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

@marcuschangarm
Copy link
Contributor Author

/morph test

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2018

@marcuschangarm
Copy link
Contributor Author

/morph test

@mbed-ci
Copy link

mbed-ci commented May 1, 2018

Delayed initialization can cause problems when both UARTE instances
are in use. This change causes each UART object to initialize the
underlying UARTE instance immediately.
@marcuschangarm
Copy link
Contributor Author

/morph build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

Build : SUCCESS

Build number : 1892
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6771/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 2, 2018

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

How does PR affects lp timeout? 😕 An issue on master with this test and the target?

@marcuschangarm
Copy link
Contributor Author

How does PR affects lp timeout? 😕 An issue on master with this test and the target?

It doesn't. @studavekar and I suspects that something was merged the past week that introduces some instability on the NRF52. That's when the instability began.

@0xc0170
Copy link
Contributor

0xc0170 commented May 7, 2018

It should be now green

/morph build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

Build : SUCCESS

Build number : 1927
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6771/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@mbed-ci
Copy link

mbed-ci commented May 7, 2018

@cmonr cmonr merged commit e023bb6 into ARMmbed:master May 7, 2018
@marcuschangarm marcuschangarm deleted the fix-uart-init branch May 10, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants