Skip to content

Enlarge timer thread stack size for Cortex-M23/M33 #6773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Apr 30, 2018

Description

This PR tries to enlarge default size of timer thread stack for Cortex-M23/M33 targets. The adjustment is based on port of our on-going NUMAKER_PFM_M2351 target.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@deepikabhavnani deepikabhavnani requested a review from c1728p9 April 30, 2018 18:56
@deepikabhavnani
Copy link

Increasing timer stack size for all devices (including the ones which do not support trustZone and have limited RAM memory) does not make sense. Shall we have config option for timer stack size?

@ccli8
Copy link
Contributor Author

ccli8 commented May 2, 2018

@deepikabhavnani I change back the default size of timer thread but keep the configuration option for it in 438788b.

@deepikabhavnani
Copy link

@ccli8 - Having config option is good. It will be good to have additional define MBED_CONF_xxx as config similar to others (MBED_CONF_APP_THREAD_STACK_SIZE)

@ccli8 ccli8 force-pushed the nuvoton_fix_timer_stack_size branch from 438788b to 7b94d4d Compare May 3, 2018 01:51
@ccli8
Copy link
Contributor Author

ccli8 commented May 3, 2018

@deepikabhavnani I add the macros MBED_CONF_APP_TIMER_THREAD_STACK_SIZE/MBED_CONF_APP_IDLE_THREAD_STACK_SIZE for configuration by user application.

@0xc0170 0xc0170 requested a review from deepikabhavnani May 3, 2018 11:50
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 3, 2018

Build : SUCCESS

Build number : 1914
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6773/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepikabhavnani Any documentation needed for this extension?

Having this configuration documented for rtos like main thread stack size, this timer thread stack size, etc ?

@mbed-ci
Copy link

mbed-ci commented May 4, 2018

@deepikabhavnani
Copy link

Any documentation needed for this extension?

👍 Added PR in handbook. ARMmbed/mbed-os-5-docs#510

@cmonr cmonr merged commit 7a99cd1 into ARMmbed:master May 7, 2018
@ccli8 ccli8 deleted the nuvoton_fix_timer_stack_size branch December 20, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants