-
Notifications
You must be signed in to change notification settings - Fork 3k
Enlarge timer thread stack size for Cortex-M23/M33 #6773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enlarge timer thread stack size for Cortex-M23/M33 #6773
Conversation
Increasing timer stack size for all devices (including the ones which do not support trustZone and have limited RAM memory) does not make sense. Shall we have config option for timer stack size? |
@deepikabhavnani I change back the default size of timer thread but keep the configuration option for it in 438788b. |
@ccli8 - Having config option is good. It will be good to have additional define |
Configuration for changing this size is kept.
…e thread stack size by application
438788b
to
7b94d4d
Compare
@deepikabhavnani I add the macros |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
/morph build |
Build : SUCCESSBuild number : 1914 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1560 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deepikabhavnani Any documentation needed for this extension?
Having this configuration documented for rtos like main thread stack size, this timer thread stack size, etc ?
Test : SUCCESSBuild number : 1731 |
👍 Added PR in handbook. ARMmbed/mbed-os-5-docs#510 |
Description
This PR tries to enlarge default size of timer thread stack for Cortex-M23/M33 targets. The adjustment is based on port of our on-going NUMAKER_PFM_M2351 target.
Pull request type